Ticket #22839: 22839.4.diff

src/wp-admin/css/customize-controls.css

@@ -32 +32 @@
         margin-right: 4px;
 }
 
-.saving #customize-header-actions .spinner {
-        display: block;
-}
-
 #customize-header-actions {
         border-bottom: 1px solid #ddd;
 }

src/wp-admin/js/dashboard.js

@@ -68 +68 @@
                 $( '#quick-press .submit input[type="submit"], #quick-press .submit input[type="reset"]' ).prop( 'disabled' , false );
 
                 t = $('#quick-press').submit( function() {
-                        $('#dashboard_quick_press #publishing-action .spinner').show();
+                        $( '#dashboard_quick_press #publishing-action .spinner' ).addClass( 'is-active' );
                         $('#quick-press .submit input[type="submit"], #quick-press .submit input[type="reset"]').prop('disabled', true);
 
                         $.post( t.attr( 'action' ), t.serializeArray(), function( data ) {

src/wp-admin/js/edit-comments.js

@@ -352 +352 @@
                 $('#replycontent').css('height', '').val('');
                 $('#edithead input').val('');
                 $('.error', replyrow).html('').hide();
-                $('.spinner', replyrow).hide();
+                $( '.spinner', replyrow ).removeClass( 'is-active' );
 
                 this.cid = '';
         },
@@ -442 +442 @@
                 var post = {};
 
                 $('#replysubmit .error').hide();
-                $('#replysubmit .spinner').show();
+                $( '#replysubmit .spinner' ).addClass( 'is-active' );
 
                 $('#replyrow input').not(':button').each(function() {
                         var t = $(this);
@@ -525 +525 @@
         error : function(r) {
                 var er = r.statusText;
 
-                $('#replysubmit .spinner').hide();
+                $( '#replysubmit .spinner' ).removeClass( 'is-active' );
 
                 if ( r.responseText )
                         er = r.responseText.replace( /<.[^<>]*?>/g, '' );

src/wp-admin/js/image-edit.js

@@ -306 +306 @@
                         btn = $('#imgedit-open-btn-' + postid), spin = btn.siblings('.spinner');
 
                 btn.prop('disabled', true);
-                spin.show();
+                spin.addClass( 'is-active' );
 
                 data = {
                         'action': 'image-editor',
@@ -324 +324 @@
                         head.fadeOut('fast', function(){
                                 elem.fadeIn('fast');
                                 btn.removeAttr('disabled');
-                                spin.hide();
+                                spin.removeClass( 'is-active' );
                         });
                 });
 

src/wp-admin/js/inline-edit-post.js

@@ -243 +243 @@
                         id = this.getId(id);
                 }
 
-                $('table.widefat .spinner').show();
+                $( 'table.widefat .spinner' ).addClass( 'is-active' );
 
                 params = {
                         action: 'inline-save',
@@ -259 +259 @@
                 // make ajax request
                 $.post( ajaxurl, params,
                         function(r) {
-                                $('table.widefat .spinner').hide();
+                                $( 'table.widefat .spinner' ).removeClass( 'is-active' );
 
                                 if (r) {
                                         if ( -1 !== r.indexOf( '<tr' ) ) {
@@ -282 +282 @@
                 var id = $('table.widefat tr.inline-editor').attr('id');
 
                 if ( id ) {
-                        $('table.widefat .spinner').hide();
+                        $( 'table.widefat .spinner' ).removeClass( 'is-active' );
 
                         if ( 'bulk-edit' === id ) {
                                 $('table.widefat #bulk-edit').removeClass('inline-editor').hide().siblings('tr.hidden').remove();

src/wp-admin/js/inline-edit-tax.js

@@ -74 +74 @@
                         id = this.getId(id);
                 }
 
-                $('table.widefat .spinner').show();
+                $( 'table.widefat .spinner' ).addClass( 'is-active' );
 
                 params = {
                         action: 'inline-save-tax',

src/wp-admin/js/nav-menu.js

@@ -177 +177 @@
                                                         return false;
 
                                                 // Show the ajax spinner
-                                                t.find('.spinner').show();
+                                                t.find( '.spinner' ).addClass( 'is-active' );
 
                                                 // Retrieve menu item data
                                                 $(checkboxes).each(function(){
@@ -194 +194 @@
                                                 api.addItemToMenu(menuItems, processMethod, function(){
                                                         // Deselect the items and hide the ajax spinner
                                                         checkboxes.removeAttr('checked');
-                                                        t.find('.spinner').hide();
+                                                        t.find( '.spinner' ).removeClass( 'is-active' );
                                                 });
                                         });
                                 },
@@ -877 +877 @@
                                 'type': input.attr('name')
                         };
 
-                        $('.spinner', panel).show();
+                        $( '.spinner', panel ).addClass( 'is-active' );
 
                         $.post( ajaxurl, params, function(menuMarkup) {
                                 api.processQuickSearchQueryResponse(menuMarkup, params, panel);
@@ -894 +894 @@
                                 return false;
 
                         // Show the ajax spinner
-                        $('.customlinkdiv .spinner').show();
+                        $( '.customlinkdiv .spinner' ).addClass( 'is-active' );
                         this.addLinkToMenu( url, label, processMethod, function() {
                                 // Remove the ajax spinner
-                                $('.customlinkdiv .spinner').hide();
+                                $( '.customlinkdiv .spinner' ).removeClass( 'is-active' );
                                 // Set custom link form back to defaults
                                 $('#custom-menu-item-name').val('').blur();
                                 $('#custom-menu-item-url').val('http://');
@@ -1145 +1145 @@
 
                         if( ! $items.length ) {
                                 $('.categorychecklist', panel).html( '<li><p>' + navMenuL10n.noResultsFound + '</p></li>' );
-                                $('.spinner', panel).hide();
+                                $( '.spinner', panel ).removeClass( 'is-active' );
                                 return;
                         }
 
@@ -1172 +1172 @@
                         });
 
                         $('.categorychecklist', panel).html( $items );
-                        $('.spinner', panel).hide();
+                        $( '.spinner', panel ).removeClass( 'is-active' );
                 },
 
                 removeMenuItem : function(el) {

src/wp-admin/js/post.js

@@ -193 +193 @@
 
                 this.st += num;
                 this.total = total;
-                $('#commentsdiv .spinner').show();
+                $( '#commentsdiv .spinner' ).addClass( 'is-active' );
 
                 data = {
                         'action' : 'get-comments',
@@ -208 +208 @@
                         function(r) {
                                 r = wpAjax.parseAjaxResponse(r);
                                 $('#commentsdiv .widefat').show();
-                                $('#commentsdiv .spinner').hide();
+                                $( '#commentsdiv .spinner' ).removeClass( 'is-active' );
 
                                 if ( 'object' == typeof r && r.responses[0] ) {
                                         $('#the-comment-list').append( r.responses[0].data );

src/wp-admin/js/widgets.js

@@ -340 +340 @@
                         data = widget.find('form').serialize(), a;
 
                 widget = $(widget);
-                $('.spinner', widget).show();
+                $( '.spinner', widget ).addClass( 'is-active' );
 
                 a = {
                         action: 'save-widget',
@@ -377 +377 @@
                                         widget.remove();
                                 }
                         } else {
-                                $('.spinner').hide();
+                                $( '.spinner' ).removeClass( 'is-active' );
                                 if ( r && r.length > 2 ) {
                                         $( 'div.widget-content', widget ).html( r );
                                         wpWidgets.appendTitle( widget );

src/wp-admin/options-general.php

@@ -60 +60 @@
                 });
                 $("input[name='date_format_custom'], input[name='time_format_custom']").change( function() {
                         var format = $(this);
-                        format.siblings('.spinner').css('display', 'inline-block'); // show(); can't be used here
+                        format.siblings( '.spinner' ).addClass( 'is-active' );
                         $.post(ajaxurl, {
                                         action: 'date_format_custom' == format.attr('name') ? 'date_format' : 'time_format',
                                         date : format.val()
-                                }, function(d) { format.siblings('.spinner').hide(); format.siblings('.example').text(d); } );
+                                }, function( d ) { format.siblings( '.spinner' ).removeClass( 'is-active' ); format.siblings( '.example' ).text( d ); } );
                 });
 
                 var languageSelect = $( '#WPLANG' );

src/wp-admin/press-this.php

@@ -451 +451 @@
                         show('photo');
                 <?php } ?>
                 jQuery('#title').unbind();
-                jQuery('#publish, #save').click(function() { jQuery('.press-this #publishing-actions .spinner').css('display', 'inline-block'); });
+                jQuery( '#publish, #save' ).click(function() { jQuery( '.press-this #publishing-actions .spinner' ).addClass( 'is-active' ); } );
 
                 $('#tagsdiv-post_tag, #categorydiv').children('h3, .handlediv').click(function(){
                         $(this).siblings('.inside').toggle();
@@ -497 +497 @@
                                                         echo '<br /><br />';
                                                         submit_button( __( 'Submit for Review' ), 'primary', 'review', false );
                                                 } ?>
-                                                <span class="spinner" style="display: none;"></span>
+                                                <span class="spinner"></span>
                                         </p>
                                         <?php if ( current_theme_supports( 'post-formats' ) && post_type_supports( 'post', 'post-formats' ) ) :
                                                         $post_formats = get_theme_support( 'post-formats' );

src/wp-includes/css/editor.css

@@ -1371 +1371 @@
 }
 
 #wp-link .link-search-wrapper .spinner {
-        display: none;
         vertical-align: text-bottom;
 }
 

src/wp-includes/css/media-views.css

@@ -1785 +1785 @@
         right: 26px;
 }
 
-.media-frame .embed-loading .embed-url .spinner {
-        display: block;
-}
-
 .embed-link-settings,
 .embed-media-settings {
         position: absolute;