Ticket #23040: class-wp-theme.php.patch

class-wp-theme.php

@@ -299 +299 @@
 
         /**
          * __isset() magic method for properties formerly returned by current_theme_info()
+     * Use appropriate method to obtain WP_Theme properties.
          */
         public function __isset( $offset ) {
+        
+        _doing_it_wrong( __METHOD__, sprintf( __( 'Please use the appropriate, public WP_Theme method: %s.' ), $this->_deprecated( $offset ) ), '3.7' );
                 static $properties = array(
                         'name', 'title', 'version', 'parent_theme', 'template_dir', 'stylesheet_dir', 'template', 'stylesheet',
                         'screenshot', 'description', 'author', 'tags', 'theme_root', 'theme_root_uri',
@@ -308 +311 @@
 
                 return in_array( $offset, $properties );
         }
+    
+    /**
+         * Generate appropriate WP_Theme method for _doing_it_wrong notice.
+         */
+    private function _deprecated( $offset ) {
+        $properties = array(
+                        'name'           => "wp_get_theme()->get('Name')",
+            'title'          => "wp_get_theme()->get('Name')",
+            'version'        => "wp_get_theme()->get('Version')",
+            'parent_theme'   => "wp_get_theme()->parent() ? wp_get_theme()->->parent() : wp_get_theme()->get('Name')",
+            'template_dir'   => "wp_get_theme()->get_template_directory()",
+            'stylesheet_dir' => "wp_get_theme()->get_stylesheet_directory()",
+            'template'       => "wp_get_theme()->get_template()",
+            'stylesheet'     => "wp_get_theme()->get_stylesheet()",
+                        'screenshot'     => "wp_get_theme()->get_screenshot()",
+            'description'    => "wp_get_theme()->display('description')",
+            'author'         => "wp_get_theme()->display('author')",
+            'tags'           => "wp_get_theme()->get('Tags')",
+            'theme_root'     => "wp_get_theme()->get_theme_root()",
+            'theme_root_uri' => "wp_get_theme()->get_theme_root_uri()",
+            'default'        => "wp_get_theme()->offsetGet( $offset )",
+                );
+        return isset( $properties[ $offset ] ) ? $properties[ $offset ] : $properties['default'];
+    }
 
         /**
          * __get() magic method for properties formerly returned by current_theme_info()
+     * Use appropriate method to obtain WP_Theme properties.
          */
         public function __get( $offset ) {
+        _doing_it_wrong( __METHOD__, sprintf( __( 'Please use the appropriate, public WP_Theme method: %s.' ), $this->_deprecated( $offset ) ), '3.7' );
+        
                 switch ( $offset ) {
                         case 'name' :
                         case 'title' :
@@ -362 +392 @@
          * Method to implement ArrayAccess for keys formerly returned by get_themes()
          */
         public function offsetExists( $offset ) {
+        _deprecated_function( __METHOD__, sprintf( __( 'Please use the appropriate, public WP_Theme method: %s.' ), $this->_deprecated( $offset ) ), '3.7' );
                 static $keys = array(
                         'Name', 'Version', 'Status', 'Title', 'Author', 'Author Name', 'Author URI', 'Description',
                         'Template', 'Stylesheet', 'Template Files', 'Stylesheet Files', 'Template Dir', 'Stylesheet Dir',