Ticket #23133: cron.php.diff

src/wp-includes/cron.php

@@ -244 +244 @@
         $keys = array_keys( $crons );
         if ( isset($keys[0]) && $keys[0] > $gmt_time )
                 return;
+        
+        // maybe force alternate cron if server setup is unusual
+        $force_alternate_wp_cron = _maybe_force_alternate_wp_cron();
 
-        if ( defined( 'ALTERNATE_WP_CRON' ) && ALTERNATE_WP_CRON ) {
+        if ( $force_alternate_wp_cron || ( defined( 'ALTERNATE_WP_CRON' ) && ALTERNATE_WP_CRON ) ) {
                 if ( ! empty( $_POST ) || defined( 'DOING_AJAX' ) ||  defined( 'XMLRPC_REQUEST' ) ) {
                         return;
                 }
@@ -302 +305 @@
 }
 
 /**
+ * Test the server setup to see if we need to fallback to the 'alternate cron' method.
+ * Some server setups, for some reason do not allow loopback http requests. This
+ * function specifically tests whether that functionality is available, and cachees
+ * the result for 12 hours.
+ *
+ * @since 4.0.1
+ *
+ * @return bool True, if we need to force alternate cron because of server setup, False otherwise
+ */
+function _maybe_force_alternate_wp_cron() {
+
+        // if a response has been cached from earlier, then just reuse it
+        $cached_response = get_transient( 'loopback_response' );
+
+        // if no cache exists, and we are not already forcing alternate cron using another method
+        if ( ! $cached_response && defined( 'ALTERNATE_WP_CRON' ) && ALTERNATE_WP_CRON ) {
+                // cache buster
+                $rnd = substr( md5( time() . NONCE_SALT ), 10, 10 );
+
+                // create an unfiltered request to test our loopback connection with
+                $loopback_request = array(
+                        'url'  => add_query_arg( 'wp_loopback_test', $loopback_request, site_url( 'wp-cron.php' ) ),
+                        'args' => array(
+                                /* short timeout for the request */
+                                'timeout'   => 0.01,
+                                /* make this request blocking so that we get a response code */
+                                'blocking'  => true,
+                                /* force the wp-cron.php script to die early by sending post data */
+                                'body'      => array( 'wp_loopback_test_chk' => sha1( $loopback_request ) ),
+                                /** This filter is documented in wp-includes/class-http.php */
+                                'sslverify' => apply_filters( 'https_local_ssl_verify', false )
+                        )
+                );
+
+                // fetch the response from the server
+                $response = wp_remote_post( $loopback_request['url'], $loopback_request['args'] );
+
+                // default the response to an unknown error, because wp_remote_post could return a WP_Error.
+                // if the WP_Error is returned, the failure is the same as a non-200 response
+                $cached_response = 'ERROR';
+
+                // parse the response into just a response code, if it is present
+                if ( is_array($response) && isset( $response['response'], $response['response']['code'] ) ) {
+                        $cached_response = $response['response']['code'];
+                }
+
+                // cache the response
+                set_transient( 'loopback_response', $cached_response, DAY_IN_SECONDS / 2 );
+        }
+
+        // if our response is 200, then we are good. otherwise we need to force alternate cron
+        return $cached_response != 200;
+}
+
+/**
+ * Performs a check when the admin loads, to see if the server is setup so that WP Cron can
+ * function normally. Upon failure, it spawns an admin notice.
+ *
+ * @since 4.0.1
+ *
+ * @return null Simply checks and spawns a notice if needed
+ */
+function wp_cron_admin_check() {
+
+        // check if the cron is currently being forced to use the 'alternate cron' method
+        // only perform this check if the current user needs to know about it
+        // Issue: https://core.trac.wordpress.org/ticket/23133
+        // ticket was created in regards to failed future posts, which is handled by cron,
+        // thus the edit_posts permission sounds most logical
+        if ( current_user_can( 'edit_posts' ) &&  _maybe_force_alternate_wp_cron() ) {
+                // if we are currently forcing it, then add a notice about it in the admin
+                add_action( 'admin_notices', 'wp_cron_admin_check_failed_message' );
+        }
+}
+add_action( 'admin_init', 'wp_cron_admin_check' );
+
+/**
+ * Displays an admin notice, informing the admin user they have been switched to the
+ * Alternative Cron method. Definitely needs some verbiage work, and probably a translation.
+ *
+ * @since 4.0.1
+ *
+ * @return null Simply displays a message
+ */
+function wp_cron_admin_check_failed_message() {
+        echo '<div id="alternate-cron-force" class="error"><p>';
+        echo __( 'Your server is preventing WP Cron from functioning properly. ' );
+        echo __( 'As a fallback, you have been switched to using <a href="http://codex.wordpress.org/Editing_wp-config.php#Alternative_Cron">Alternative Cron</a> for now. ' );
+        echo '</p></div>';
+}
+
+/**
  * Run scheduled callbacks or spawn cron for all scheduled events.
  *
  * @since 2.1.0