Ticket #23498: 23498.2.diff

src/wp-includes/author-template.php

@@ -334 +334 @@
 
         $query_args = wp_array_slice_assoc( $args, array( 'orderby', 'order', 'number', 'exclude', 'include' ) );
         $query_args['fields'] = 'ids';
+
+        if( $args['exclude_admin'] == true ) { 
+                $exclude = get_users( array( 'role' => 'administrator' ) ); 
+                foreach ( $exclude as $admin ) { 
+                        $exclude_ids[] = $admin->ID; 
+                } 
+                $query_args['exclude'] = $exclude_ids; 
+        } 
+
         $authors = get_users( $query_args );
 
         $author_count = array();
@@ -343 +352 @@
         foreach ( $authors as $author_id ) {
                 $author = get_userdata( $author_id );
 
-                if ( $args['exclude_admin'] && 'admin' == $author->display_name ) {
-                        continue;
-                }
+                $posts = isset( $author_count[ $author->ID ] ) ? $author_count[ $author->ID ] : 0;
 
-                $posts = isset( $author_count[$author->ID] ) ? $author_count[$author->ID] : 0;
-
                 if ( ! $posts && $args['hide_empty'] ) {
                         continue;
                 }

tests/phpunit/tests/user/listAuthors.php

@@ -119 +119 @@
                 $this->AssertEquals( $expected['html'], wp_list_authors( array( 'echo' => false, 'html' => 0 ) ) );
         }
 
+        /**
+         * @ticket 23498
+         */
+        function test_wp_list_authors_number() {
+                $expected['number'] = '<li><a href="http://example.org/?author=' . $this->users[1] . '" title="Posts by bob">bob</a></li><li><a href="http://example.org/?author=' . $this->users[2] . '" title="Posts by paul">paul</a></li>';
+                $this->AssertEquals( $expected['number'], wp_list_authors( array( 'echo' => false, 'number' => 2 ) ) );
+        }
+
 }