Ticket #23498: 23498.3.diff

src/wp-includes/author-template.php

@@ -355 +355 @@
 
         $query_args = wp_array_slice_assoc( $args, array( 'orderby', 'order', 'number', 'exclude', 'include' ) );
         $query_args['fields'] = 'ids';
+
+        if( true == $args['exclude_admin'] ) {  
+                $exclude = get_users( array( 'role' => 'administrator' ) );  
+                foreach ( $exclude as $admin ) {  
+                        $exclude_ids[] = $admin->ID;  
+                }  
+                $query_args['exclude'] = $exclude_ids;  
+        }
+
         $authors = get_users( $query_args );
 
         $author_count = array();
@@ -364 +373 @@
         foreach ( $authors as $author_id ) {
                 $author = get_userdata( $author_id );
 
-                if ( $args['exclude_admin'] && 'admin' == $author->display_name ) {
-                        continue;
-                }
+                $posts = isset( $author_count[ $author->ID ] ) ? $author_count[ $author->ID ] : 0;
 
-                $posts = isset( $author_count[$author->ID] ) ? $author_count[$author->ID] : 0;
-
                 if ( ! $posts && $args['hide_empty'] ) {
                         continue;
                 }

tests/phpunit/tests/user/listAuthors.php

@@ -141 +141 @@
                 $expected['html'] = 'bob, paul, zack';
                 $this->AssertEquals( $expected['html'], wp_list_authors( array( 'echo' => false, 'html' => 0 ) ) );
         }
+
+        /** 
+         * @ticket 23498 
+         */ 
+        function test_wp_list_authors_number() { 
+                $expected['number'] = '<li><a href="http://example.org/?author=' . $this->users[1] . '" title="Posts by bob">bob</a></li><li><a href="http://example.org/?author=' . $this->users[2] . '" title="Posts by paul">paul</a></li>';
+                $this->AssertEquals( $expected['number'], wp_list_authors( array( 'echo' => false, 'number' => 2 ) ) ); 
+        }
 }