Ticket #23498: 23498.4.diff

src/wp-includes/author-template.php

@@ -435 +435 @@
 
         $query_args           = wp_array_slice_assoc( $args, array( 'orderby', 'order', 'number', 'exclude', 'include' ) );
         $query_args['fields'] = 'ids';
-        $authors              = get_users( $query_args );
+
+        // @link https://core.trac.wordpress.org/ticket/23498
+        if( true == $args['exclude_admin'] ) { 
+                $exclude = get_users( array( 'role' => 'administrator' ) ); 
+                foreach ( $exclude as $admin ) { 
+                        $exclude_ids[] = $admin->ID; 
+                }
+                $query_args['exclude'] = $exclude_ids; 
+        }
+
+        $authors = get_users( $query_args );
 
         $author_count = array();
         foreach ( (array) $wpdb->get_results( "SELECT DISTINCT post_author, COUNT(ID) AS count FROM $wpdb->posts WHERE " . get_private_posts_cap_sql( 'post' ) . ' GROUP BY post_author' ) as $row ) {
@@ -450 +460 @@
 
                 $author = get_userdata( $author_id );
 
-                if ( $args['exclude_admin'] && 'admin' === $author->display_name ) {
-                        continue;
-                }
-
                 if ( $args['show_fullname'] && $author->first_name && $author->last_name ) {
                         $name = "$author->first_name $author->last_name";
                 } else {

tests/phpunit/tests/user/listAuthors.php

@@ -248 +248 @@
                         )
                 );
         }
+
+        /**
+         * @ticket 23498
+         **/
+        function test_wp_list_authors_number() {
+                $expected['number'] = 
+                        '<li><a href="' . self::$user_urls[1] . '" title="Posts by bob">bob</a></li>' . 
+                        '<li><a href="' . self::$user_urls[2] . '" title="Posts by paul">paul</a></li>' .
+                        '<li><a href="' . self::$user_urls[0] . '" title="Posts by zack">zack</a></li>';
+                $a = wp_list_authors( array( 'echo' => false ) );
+                $this->AssertEquals( $expected['number'], $a );
+        }
+
 }