Ticket #23560: 23560.12.diff

src/wp-includes/css/media-views.css

@@ -1478 +1478 @@
         box-shadow: none;
 }
 
+.attachment.selection.selected:focus {
+        webkit-box-shadow: 0 0 0 1px #5b9dd9,
+         0 0 2px 2px #5b9dd9;
+        box-shadow: 0 0 0 1px #5b9dd9,
+         0 0 2px 2px #5b9dd9;
+        outline: none;
+}
+
 .attachment.selection.details {
         -webkit-box-shadow:
                 0 0 0 1px #fff,

src/wp-includes/js/media-views.js

@@ -3221 +3221 @@
                                 };
                         }
 
-                        $el.show().focus();
+                        $el.show().find( '.media-modal-close' ).focus();
                         return this.propagate('open');
                 },
 
@@ -3302 +3302 @@
                         if ( 27 === event.which && this.$el.is(':visible') ) {
                                 this.escape();
                                 event.stopImmediatePropagation();
-                        } else {
-                                // Keep focus inside the media modal
-                                this.focusManager;
                         }
                 }
         });
@@ -4404 +4401 @@
                         } else {
                                 this.click();
                         }
+                        
+                        // When selecting a tab along the left side, 
+                        // focus should be transferred into the main panel
+                        $('.media-frame-content').find( ':focusable' ).first().focus(); 
                 },
 
                 click: function() {
@@ -4735 +4736 @@
                  */
                 toggleSelectionHandler: function( event ) {
                         var method;
+                        
+                        // Catch arrow events
+                        if ( 37 === event.keyCode || 38 === event.keyCode || 39 === event.keyCode || 40 === event.keyCode ) {
+                                this.arrowEvent(event);
+                                return;
+                        }
+                        
                         // Catch enter and space events
                         if ( 'keydown' === event.type && 13 !== event.keyCode && 32 !== event.keyCode ) {
                                 return;
@@ -4755 +4763 @@
                         this.toggleSelection({
                                 method: method
                         });
+                        
+                        // When selecting an image, focus should be transferred to the right details panel
+                        $('.attachment-details').find( ':focusable' ).first().focus();
                 },
                 /**
+                 * @param {Object} event
+                 */
+                arrowEvent: function( event ) {
+                        var attachment = $('.attachments-browser .attachment'),
+                                attachmentsWidth = $('.attachments-browser .attachments').width(),
+                                thumbnailWidth = attachment.first().innerWidth() + 16,
+                                thumbnailsPerRow = Math.floor(attachmentsWidth/thumbnailWidth),
+                                totalThumnails = attachment.length,
+                                totalRows = Math.ceil(totalThumnails/thumbnailsPerRow),
+                                thisIndex = attachment.filter( ':focus' ).index(),
+                                thisIndexAdjusted = thisIndex + 1,
+                                thisRow = thisIndexAdjusted <= thumbnailsPerRow ? 1 : Math.ceil(thisIndexAdjusted/thumbnailsPerRow);
+                                
+                                // Left arrow
+                                if ( 37 === event.keyCode ) {
+                                        if ( 0 === thisIndex ) {
+                                                return;
+                                        }
+                                        attachment.eq( thisIndex - 1 ).focus();
+                                }
+                                
+                                // Up arrow
+                                if ( 38 === event.keyCode ) {
+                                        if ( 1 === thisRow ) {
+                                                return;
+                                        }
+                                        attachment.eq( thisIndex - thumbnailsPerRow ).focus();
+                                }
+                                
+                                // Right arrow
+                                if ( 39 === event.keyCode ) {
+                                        if ( totalThumnails === thisIndex ) {
+                                                return;
+                                        }
+                                        attachment.eq( thisIndex + 1 ).focus();
+                                }
+                                
+                                // Down arrow
+                                if ( 40 === event.keyCode ) {
+                                        if ( totalRows === thisRow ) {
+                                                return;
+                                        }
+                                        attachment.eq( thisIndex + thumbnailsPerRow ).focus();
+                                }
+                                
+                                return false;
+                },
+                /**
                  * @param {Object} options
                  */
                 toggleSelection: function( options ) {
@@ -6237 +6296 @@
                         'click .delete-attachment':       'deleteAttachment',
                         'click .trash-attachment':        'trashAttachment',
                         'click .edit-attachment':         'editAttachment',
-                        'click .refresh-attachment':      'refreshAttachment'
+                        'click .refresh-attachment':      'refreshAttachment',
+                        'keydown':                        'toggleSelectionHandler'
                 },
 
                 initialize: function() {
@@ -6300 +6360 @@
                         this.$el.removeClass('needs-refresh');
                         event.preventDefault();
                         this.model.fetch();
+                },
+                /**
+                 * @param {Object} event
+                 */
+                toggleSelectionHandler: function( event ) {
+                        // Reverse tabbing out of the right details panel 
+                        // should take me back to the item in the list that was being edited.
+                        if ( 'keydown' === event.type && 9 === event.keyCode && event.shiftKey && event.target === $( ':tabbable', this.$el ).filter( ':first' )[0] ) {
+                                $('.attachments-browser .details').focus();
+                                return false;
+                        }
                 }
 
         });