Ticket #23560: 23560.8.diff

wp-includes/js/media-views.js

@@ -1375 +1375 @@
                                                         frame.setState( previous );
                                                 else
                                                         frame.close();
+
+                                                // Keep focus inside media modal
+                                                // after canceling a gallery
+                                                new media.view.FocusManager({
+                                                        el: this.el
+                                                }).focus();
                                         }
                                 },
                                 separateCancel: new media.View({
@@ -1485 +1491 @@
                                         }) );
 
                                         this.controller.setState('gallery-edit');
+
+                                        // Keep focus inside media modal
+                                        // after jumping to gallery view
+                                        new media.view.FocusManager({
+                                                el: this.el
+                                        }).focus();
                                 }
                         });
                 },
@@ -1577 +1589 @@
                                 propagate: true,
                                 freeze:    true
                         });
+
+                        this.focusManager = new media.view.FocusManager({
+                                el: this.el
+                        });
                 },
 
                 prepare: function() {
@@ -1637 +1653 @@
                         if ( ! this.views.attached || ! this.$el.is(':visible') )
                                 return this;
 
-                        this.$el.hide();
+                        // Hide modal and remove restricted media modal tab focus once it's closed
+                        this.$el.hide().undelegate( 'keydown' );
+
+                        // Put focus back in useful location once modal is closed
+                        $('#wpbody-content').focus();
+
                         this.propagate('close');
 
                         // If the `freeze` option is set, restore the container's scroll position.
@@ -1683 +1704 @@
                                 this.escape();
                                 return;
                         }
+
+                        // Keep focus inside the media modal
+                        this.focusManager;
                 }
         });
 
@@ -1695 +1719 @@
                 },
 
                 focus: function() {
-                        if ( _.isUndefined( this.index ) )
-                                return;
-
-                        // Update our collection of `$tabbables`.
-                        this.$tabbables = this.$(':tabbable');
-
-                        // If tab is saved, focus it.
-                        this.$tabbables.eq( this.index ).focus();
+                        // Reset focus on first left menu item
+                        $('.media-menu-item').first().focus();
                 },
 
                 recordTab: function( event ) {
@@ -1710 +1728 @@
                         if ( 9 !== event.keyCode )
                                 return;
 
-                        // First try to update the index.
-                        if ( _.isUndefined( this.index ) )
-                                this.updateIndex( event );
-
-                        // If we still don't have an index, bail.
-                        if ( _.isUndefined( this.index ) )
-                                return;
-
-                        var index = this.index + ( event.shiftKey ? -1 : 1 );
-
-                        if ( index >= 0 && index < this.$tabbables.length )
-                                this.index = index;
-                        else
-                                delete this.index;
+                        // Keep tab focus within media modal while it's open
+                        if ( event.target === this.tabbablesLast[0] && !event.shiftKey ) {
+                                this.tabbableFirst.focus();
+                                return false;
+                        } else if ( event.target === this.tabbableFirst[0] && event.shiftKey ) {
+                                this.tabbablesLast.focus();
+                                return false;
+                        }
                 },
 
                 updateIndex: function( event ) {
-                        this.$tabbables = this.$(':tabbable');
-
-                        var index = this.$tabbables.index( event.target );
-
-                        if ( -1 === index )
-                                delete this.index;
-                        else
-                                this.index = index;
+                        // Resets tabbable elements
+                        this.tabbables = $( ':tabbable', this.$el );
+                        this.tabbableFirst = this.tabbables.filter( ':first' );
+                        this.tabbablesLast  = this.tabbables.filter( ':last' );
                 }
         });
 
@@ -2493 +2501 @@
                 className: 'attachment',
                 template:  media.template('attachment'),
 
+                attributes: {
+                        tabIndex: 0,
+                        role: 'checkbox'
+                },
+
                 events: {
                         'click .attachment-preview':      'toggleSelectionHandler',
                         'change [data-setting]':          'updateSetting',
@@ -2501 +2514 @@
                         'change [data-setting] textarea': 'updateSetting',
                         'click .close':                   'removeFromLibrary',
                         'click .check':                   'removeFromSelection',
-                        'click a':                        'preventDefault'
+                        'click a':                        'preventDefault',
+                        'keydown':                                                'toggleSelectionHandler'
                 },
 
                 buttons: {},
@@ -2509 +2523 @@
                 initialize: function() {
                         var selection = this.options.selection;
 
+                        this.$el.attr('aria-label', this.model.attributes.title).attr('aria-checked', false);
                         this.model.on( 'change:sizes change:uploading', this.render, this );
                         this.model.on( 'change:title', this._syncTitle, this );
                         this.model.on( 'change:caption', this._syncCaption, this );
@@ -2599 +2614 @@
                 toggleSelectionHandler: function( event ) {
                         var method;
 
+                        // Catch enter and space events
+                        if ( 'keydown' === event.type && 13 !== event.keyCode && 32 !== event.keyCode )
+                                return;
+
                         if ( event.shiftKey )
                                 method = 'between';
                         else if ( event.ctrlKey || event.metaKey )
@@ -2647 +2666 @@
                                 return;
                         }
 
+                        // Fixes bug that loses focus when selecting a featured image
+                        if ( !method )
+                                method = 'add';
+
                         if ( method !== 'add' )
                                 method = 'reset';
 
@@ -2682 +2705 @@
                         if ( ! selection || ( collection && collection !== selection ) )
                                 return;
 
-                        this.$el.addClass('selected');
+                        this.$el.addClass('selected').attr('aria-checked', true);
                 },
 
                 deselect: function( model, collection ) {
@@ -2694 +2717 @@
                         if ( ! selection || ( collection && collection !== selection ) )
                                 return;
 
-                        this.$el.removeClass('selected');
+                        this.$el.removeClass('selected').attr('aria-checked', false);
                 },
 
                 details: function( model, collection ) {
@@ -2876 +2899 @@
                 tagName:   'ul',
                 className: 'attachments',
 
+                attributes: {
+                        tabIndex: -1
+                },
+
                 cssTemplate: media.template('attachments-css'),
 
                 events: {
@@ -3488 +3515 @@
                 clear: function( event ) {
                         event.preventDefault();
                         this.collection.reset();
+
+                        // Keep focus inside media modal
+                        // after clear link is selected
+                        new media.view.FocusManager({
+                                el: this.el
+                        }).focus();
                 }
         });
 
@@ -3731 +3764 @@
                 },
 
                 initialize: function() {
-                        this.focusManager = new media.view.FocusManager({
-                                el: this.el
-                        });
-
                         media.view.Attachment.prototype.initialize.apply( this, arguments );
                 },
 
                 render: function() {
                         media.view.Attachment.prototype.render.apply( this, arguments );
-                        this.focusManager.focus();
                         return this;
                 },
 
@@ -3749 +3777 @@
 
                         if ( confirm( l10n.warnDelete ) )
                                 this.model.destroy();
+
+                        // Keep focus inside media modal
+                        // after image is deleted
+                        new media.view.FocusManager({
+                                el: this.el
+                        }).focus();
                 },
 
                 editAttachment: function() {
@@ -3777 +3811 @@
                 },
 
                 initialize: function() {
-                        this.focusManager = new media.view.FocusManager({
-                                el: this.el
-                        });
-
                         this.model.on( 'change:compat', this.render, this );
                 },
 
@@ -3799 +3829 @@
                         this.views.detach();
                         this.$el.html( compat.item );
                         this.views.render();
-
-                        this.focusManager.focus();
                         return this;
                 },
 

wp-includes/media-template.php

@@ -18 +18 @@
         if ( $is_IE && strpos($_SERVER['HTTP_USER_AGENT'], 'MSIE 7') !== false )
                 $class .= ' ie7';
         ?>
+        <!--[if lte IE 8]>
+        <style>
+                .attachment:focus {
+                        outline: #1e8cbe solid;
+                }
+                .selected.attachment {
+                        outline: #1e8cbe solid;
+                }
+        </style>
+        <![endif]-->
         <script type="text/html" id="tmpl-media-frame">
                 <div class="media-frame-menu"></div>
                 <div class="media-frame-title"></div>
@@ -142 +152 @@
                         <# } else if ( 'image' === data.type ) { #>
                                 <div class="thumbnail">
                                         <div class="centered">
-                                                <img src="{{ data.size.url }}" draggable="false" />
+                                                <img src="{{ data.size.url }}" draggable="false" alt="" />
                                         </div>
                                 </div>
                         <# } else { #>
@@ -157 +167 @@
                         <# } #>
 
                         <# if ( data.buttons.check ) { #>
-                                <a class="check" href="#" title="<?php _e('Deselect'); ?>"><div class="media-modal-icon"></div></a>
+                                <a class="check" href="#" title="<?php _e('Deselect'); ?>" tabindex="-1"><div class="media-modal-icon"></div></a>
                         <# } #>
                 </div>
                 <#

wp-includes/css/media-views.css

@@ -460 +460 @@
         border-right: 0;
 }
 
-.media-router > a:active,
-.media-router > a:focus {
+.media-router > a:active {
         outline: none;
 }
 
@@ -654 +653 @@
         user-select:         none;
 }
 
+.attachment:focus {
+        box-shadow: 0px 0px 2pt 2pt #1e8cbe;
+        outline: none;
+}
+
 .selected.attachment {
         box-shadow:
                 0 0 0 1px #fff,
@@ -855 +859 @@
         right: 300px;
         bottom: 0;
         overflow: auto;
+        outline: none;
 }
 
 .attachments-browser .instructions {