Ticket #23888: 23888.3.diff

wp-includes/media.php

@@ -2069 +2069 @@
                 }
         }
 
-        // these functions expected a reference, not a value
-        $_content = $post->post_content;
-        $content =& $_content;
+        // these functions expect a reference, so we should make a copy of post content to avoid changing it
+        $content = $post->post_content;
 
         $htmls = get_content_media( $type, $content, true, true );
         if ( ! empty( $htmls ) ) {
@@ -2386 +2385 @@
 
                 $count = 1;
                 $matches = array();
-                $content =& $post->post_content;
+                $content = $post->post_content;
 
                 if ( preg_match_all( '/' . get_shortcode_regex() . '/s', $content, $matches, PREG_SET_ORDER ) && ! empty( $matches ) ) {
                         foreach ( $matches as $shortcode ) {
@@ -2415 +2414 @@
                 return $post->format_content;
         }
 
-        $content =& $post->post_content;
+        $content = $post->post_content;
         $htmls = get_content_images( $content, true, true, 1 );
         if ( ! empty( $htmls ) ) {
                 $html = reset( $htmls );