Ticket #24210: 24210.patch

wp-admin/includes/ajax-actions.php

@@ -1023 +1023 @@
 
         $role = current( $user_object->roles );
 
+        ob_start();
+        $wp_list_table->single_row( $user_object, '', $role );
+        $user_row = ob_get_clean();
+
         $x = new WP_Ajax_Response( array(
                 'what' => 'user',
                 'id' => $user_id,
-                'data' => $wp_list_table->single_row( $user_object, '', $role ),
+                'data' => $user_row,
                 'supplemental' => array(
                         'show-link' => sprintf(__( 'User <a href="#%s">%s</a> added' ), "user-$user_id", $user_object->user_login),
                         'role' => $role,
@@ -1415 +1419 @@
                 $parent = $parent_tag->parent;
                 $level++;
         }
-        echo $wp_list_table->single_row( $tag, $level );
+        $wp_list_table->single_row( $tag, $level );
         wp_die();
 }
 

wp-admin/includes/class-wp-comments-list-table.php

@@ -315 +315 @@
                 $this->user_can = current_user_can( 'edit_comment', $comment->comment_ID );
 
                 echo "<tr id='comment-$comment->comment_ID' class='$the_comment_class'>";
-                echo $this->single_row_columns( $comment );
+                $this->single_row_columns( $comment );
                 echo "</tr>\n";
         }
 

wp-admin/includes/class-wp-list-table.php

@@ -826 +826 @@
                 $row_class = ( $row_class == '' ? ' class="alternate"' : '' );
 
                 echo '<tr' . $row_class . '>';
-                echo $this->single_row_columns( $item );
+                $this->single_row_columns( $item );
                 echo '</tr>';
         }
 

wp-admin/includes/class-wp-posts-list-table.php

@@ -382 +382 @@
                         if ( $count >= $end )
                                 break;
 
-                        if ( $count >= $start )
-                                echo "\t" . $this->single_row( $page, $level );
+                        if ( $count >= $start ) {
+                                echo "\t";
+                                $this->single_row( $page, $level );
+                        }
 
                         $count++;
 
@@ -397 +399 @@
                                 foreach ( $orphans as $op ) {
                                         if ( $count >= $end )
                                                 break;
-                                        if ( $count >= $start )
-                                                echo "\t" . $this->single_row( $op, 0 );
+
+                                        if ( $count >= $start ) {
+                                                echo "\t";
+                                                $this->single_row( $op, 0 );
+                                        }
+
                                         $count++;
                                 }
                         }
@@ -444 +450 @@
                                 }
                                 $num_parents = count( $my_parents );
                                 while ( $my_parent = array_pop( $my_parents ) ) {
-                                        echo "\t" . $this->single_row( $my_parent, $level - $num_parents );
+                                        echo "\t";
+                                        $this->single_row( $my_parent, $level - $num_parents );
                                         $num_parents--;
                                 }
                         }
 
-                        if ( $count >= $start )
-                                echo "\t" . $this->single_row( $page, $level );
+                        if ( $count >= $start ) {
+                                echo "\t";
+                                $this->single_row( $page, $level );
+                        }
 
                         $count++;
 

wp-admin/includes/class-wp-terms-list-table.php

@@ -156 +156 @@
                 } else {
                         $terms = get_terms( $taxonomy, $args );
                         foreach ( $terms as $term )
-                                $out .= $this->single_row( $term, 0, $taxonomy );
+                                $this->single_row( $term, 0, $taxonomy );
                         $count = $number; // Only displaying a single page.
                 }
 
@@ -199 +199 @@
 
                                 $num_parents = count( $my_parents );
                                 while ( $my_parent = array_pop( $my_parents ) ) {
-                                        $output .=  "\t" . $this->single_row( $my_parent, $level - $num_parents, $taxonomy );
+                                        $output .=  "\t";
+                                        $this->single_row( $my_parent, $level - $num_parents, $taxonomy );
                                         $num_parents--;
                                 }
                         }
 
-                        if ( $count >= $start )
-                                $output .= "\t" . $this->single_row( $term, $level, $taxonomy );
+                        if ( $count >= $start ) {
+                                $output .= "\t";
+                                $this->single_row( $term, $level, $taxonomy );
+                        }
 
                         ++$count;
 
@@ -225 +228 @@
                 $this->level = $level;
 
                 echo '<tr id="tag-' . $tag->term_id . '"' . $row_class . '>';
-                echo $this->single_row_columns( $tag );
+                $this->single_row_columns( $tag );
                 echo '</tr>';
         }
 

wp-admin/includes/class-wp-users-list-table.php

@@ -209 +209 @@
                                 continue;
 
                         $style = ( ' class="alternate"' == $style ) ? '' : ' class="alternate"';
-                        echo "\n\t", $this->single_row( $user_object, $style, $role, isset( $post_counts ) ? $post_counts[ $userid ] : 0 );
+                        echo "\n\t";
+                        $this->single_row( $user_object, $style, $role, isset( $post_counts ) ? $post_counts[ $userid ] : 0 );
                 }
         }
 

wp-admin/includes/theme-install.php

@@ -153 +153 @@
 function display_theme( $theme ) {
         _deprecated_function( __FUNCTION__, '3.4' );
         global $wp_list_table;
-        return $wp_list_table->single_row( $theme );
+        $wp_list_table->single_row( $theme );
 }
 
 /**