Ticket #24461: patch.diff

tests/phpunit/tests/term/getTerms.php

@@ -394 +394 @@
                 add_filter( 'wp_update_term_parent', 'wp_check_term_hierarchy_for_loops', 10, 3 );
         }
 
+        /**
+         * @covers ::_get_term_children
+         */
+        public function test_get_term_children_handles_cycles() {
+                remove_filter( 'wp_update_term_parent', 'wp_check_term_hierarchy_for_loops', 10 );
+
+                $parent = $this->factory->category->create();
+                $child = $this->factory->category->create( array( 'parent' => $parent ) );
+                wp_update_term( $parent, 'category', array( 'parent' => $child ) );
+
+                add_filter( 'wp_update_term_parent', 'wp_check_term_hierarchy_for_loops', 10, 3 );
+
+                $result = _get_term_children( $parent, array( $parent, $child ), 'category' );
+
+                $this->assertEquals( array( $child ), $result );
+        }
+
         public function test_get_terms_by_slug() {
                 $t1 = $this->factory->tag->create( array( 'slug' => 'foo' ) );
                 $t2 = $this->factory->tag->create( array( 'slug' => 'bar' ) );