Ticket #24824: tck24824.2.diff

src/wp-includes/post.php

@@ -321 +321 @@
         $file = get_post_meta( $attachment_id, '_wp_attached_file', true );
 
         // If the file is relative, prepend upload dir.
-        if ( $file && 0 !== strpos( $file, '/' ) && ! preg_match( '|^.:\\\|', $file ) && ( ( $uploads = wp_get_upload_dir() ) && false === $uploads['error'] ) ) {
-                $file = $uploads['basedir'] . "/$file";
+        if ( ( $uploads = wp_get_upload_dir() ) && ! preg_match('|://|', $file) && false === $uploads['error'] ) {
+                $file = path_join($uploads['basedir'], $file);
         }
 
         if ( $unfiltered ) {

tests/phpunit/tests/post.php

@@ -1354 +1354 @@
                 $this->assertEquals( $changeset_data, json_decode( get_post( $post_id )->post_content, true ) );
         }
 
+        /**
+         * Test Absolute URL path.
+         *
+         * @ticket 24824
+         */
+        public function test_get_attached_file() {
+
+                $post = self::factory()->post->create_and_get(
+                        array(
+                                'post_title' => 'example-page',
+                                'post_type'  => 'post',
+                        )
+                );
+
+                // Absolute URL path.
+                $attachment      = self::factory()->attachment->create_and_get(
+                        array(
+                                'post_parent' => $post->ID,
+                                'file'        => 'https://example.com/index.html',
+                        )
+                );
+                $attachment_path = get_attached_file( $attachment->ID );
+                $this->assertEquals( $attachment_path, 'https://example.com/index.html' );
+        }
 }