Ticket #25187: 25187.6.diff

tests/qunit/wp-admin/js/password-strength-meter.js

@@ +1 @@
+/* global passwordStrength:true */
+/* global wp:true */
 jQuery( function() {
         module( 'password-strength-meter' );
 
+        test( 'shape: window.passwordStrength()', function() {
+                equal( typeof window.passwordStrength, 'function' );
+        });
+
         test( 'mismatched passwords should return 5', function() {
                 equal( passwordStrength( 'password1', 'username', 'password2' ), 5, 'mismatched passwords return 5' );
         });
@@ -12 +18 @@
         test( 'long complicated passwords should return 4', function() {
                 var password = function( length ) {
                         var possibility = 'abcdefghijklnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789',
-                                retVal = '';
-                        for ( var i = 0, n = possibility.length; i < length; i++ ) {
+                                retVal = '',
+                                i = 0,
+                                n = possibility.length;
+                        for (; i < length; i++ ) {
                                 retVal += possibility.charAt( Math.floor( Math.random() * n ) );
                         }
                         return retVal + 'aB2'; // add a lower case, uppercase and number just to make sure we always have one of each
@@ -36 +44 @@
 
         test( 'zxcvbn password tests should return the score we expect', function() {
                 var passwords = [
-                        { pw: 'zxcvbn', score: 0 },
-                        { pw: 'qwER43@!', score: 1 },
-                        { pw: 'Tr0ub4dour&3', score: 2 },
-                        { pw: 'correcthorsebatterystaple', score: 4 },
-                        { pw: 'coRrecth0rseba++ery9.23.2007staple$', score: 4 },
-                        { pw: 'D0g..................', score: 0 },
-                        { pw: 'abcdefghijk987654321', score: 0 },
-                        { pw: 'neverforget13/3/1997', score: 2 },
-                        { pw: '1qaz2wsx3edc', score: 0 },
-                        { pw: 'temppass22', score: 1 },
-                        { pw: 'briansmith', score: 0 },
-                        { pw: 'briansmith4mayor', score: 0 },
-                        { pw: 'password1', score: 0 },
-                        { pw: 'viking', score: 0 },
-                        { pw: 'thx1138', score: 0 },
-                        { pw: 'ScoRpi0ns', score: 0 },
-                        { pw: 'do you know', score: 0 },
-                        { pw: 'ryanhunter2000', score: 0 },
-                        { pw: 'rianhunter2000', score: 1 },
-                        { pw: 'asdfghju7654rewq', score: 2 },
-                        { pw: 'AOEUIDHG&*()LS_', score: 2 },
-                        { pw: '12345678', score: 0 },
-                        { pw: 'defghi6789', score: 0 },
-                        { pw: 'rosebud', score: 0 },
-                        { pw: 'Rosebud', score: 0 },
-                        { pw: 'ROSEBUD', score: 0 },
-                        { pw: 'rosebuD', score: 0 },
-                        { pw: 'ros3bud99', score: 0 },
-                        { pw: 'r0s3bud99', score: 0 },
-                        { pw: 'R0$38uD99', score: 1 },
-                        { pw: 'verlineVANDERMARK', score: 1 },
-                        { pw: 'eheuczkqyq', score: 4 },
-                        { pw: 'rWibMFACxAUGZmxhVncy', score: 4 },
-                        { pw: 'Ba9ZyWABu99[BK#6MBgbH88Tofv)vs$w', score: 4 }
-                ];
+                                { pw: 'zxcvbn', score: 0 },
+                                { pw: 'qwER43@!', score: 1 },
+                                { pw: 'Tr0ub4dour&3', score: 2 },
+                                { pw: 'correcthorsebatterystaple', score: 4 },
+                                { pw: 'coRrecth0rseba++ery9.23.2007staple$', score: 4 },
+                                { pw: 'D0g..................', score: 0 },
+                                { pw: 'abcdefghijk987654321', score: 0 },
+                                { pw: 'neverforget13/3/1997', score: 2 },
+                                { pw: '1qaz2wsx3edc', score: 0 },
+                                { pw: 'temppass22', score: 1 },
+                                { pw: 'briansmith', score: 0 },
+                                { pw: 'briansmith4mayor', score: 0 },
+                                { pw: 'password1', score: 0 },
+                                { pw: 'viking', score: 0 },
+                                { pw: 'thx1138', score: 0 },
+                                { pw: 'ScoRpi0ns', score: 0 },
+                                { pw: 'do you know', score: 0 },
+                                { pw: 'ryanhunter2000', score: 0 },
+                                { pw: 'rianhunter2000', score: 1 },
+                                { pw: 'asdfghju7654rewq', score: 2 },
+                                { pw: 'AOEUIDHG&*()LS_', score: 2 },
+                                { pw: '12345678', score: 0 },
+                                { pw: 'defghi6789', score: 0 },
+                                { pw: 'rosebud', score: 0 },
+                                { pw: 'Rosebud', score: 0 },
+                                { pw: 'ROSEBUD', score: 0 },
+                                { pw: 'rosebuD', score: 0 },
+                                { pw: 'ros3bud99', score: 0 },
+                                { pw: 'r0s3bud99', score: 0 },
+                                { pw: 'R0$38uD99', score: 1 },
+                                { pw: 'verlineVANDERMARK', score: 1 },
+                                { pw: 'eheuczkqyq', score: 4 },
+                                { pw: 'rWibMFACxAUGZmxhVncy', score: 4 },
+                                { pw: 'Ba9ZyWABu99[BK#6MBgbH88Tofv)vs$w', score: 4 }
+                        ],
+                        i = 0;
 
-                for ( var i = 0; i < passwords.length; i++ ) {
+                for ( ; i < passwords.length; i++ ) {
                         equal( passwordStrength( passwords[i].pw, 'username', passwords[i].pw ), passwords[i].score, 'password of `' + passwords[i].pw + '` returns ' + passwords[i].score );
                 }
         });

tests/qunit/.jshintrc

@@ +1 @@
+{
+        "globals": {
+                "asyncTest": false,
+                "deepEqual": false,
+                "define": false,
+                "DOMParser": false,
+                "equal": false,
+                "expect": false,
+                "moduleTeardown": false,
+                "notEqual": false,
+                "notStrictEqual": false,
+                "ok": false,
+                "QUnit": false,
+                "raises": false,
+                "require": false,
+                "start": false,
+                "stop": false,
+                "strictEqual": false,
+
+                "jQuery": true,
+                "module": true,
+                "test": true
+        }
+}