Ticket #25268: 25268.diff

wp-admin/includes/post.php

@@ -739 +739 @@
 /**
  * Replace hrefs of attachment anchors with up-to-date permalinks.
  *
- * @since 2.3.0
+ * @since 2.0.0
  * @access private
  *
- * @param unknown_type $post_ID
- * @return unknown
+ * @param int|object $post_ID Post ID or post object.
+ * @return void|int|WP_Error Void if nothing fixed. 0 or WP_Error on update failure. The post ID on update success.
  */
 function _fix_attachment_links( $post_ID ) {
         $post = get_post( $post_ID, ARRAY_A );
         $content = $post['post_content'];
 
-        // quick sanity check, don't run if no pretty permalinks or post is not published
-        if ( !get_option('permalink_structure') || $post['post_status'] != 'publish' )
+        // quick sanity check, don't run if no pretty permalinks, it's an attachment or post is a draft or pending
+        if ( ! get_option( 'permalink_structure' ) || 'attachment' == $post['post_type'] || in_array( $post['post_status'], array( 'draft', 'pending', 'auto-draft' ) ) )
                 return;
-
+        
         // Short if there aren't any links or no '?attachment_id=' strings (strpos cannot be zero)
         if ( !strpos($content, '?attachment_id=') || !preg_match_all( '/<a ([^>]+)>[\s\S]+?<\/a>/', $content, $link_matches ) )
                 return;