Ticket #25325: 25325.6.diff

wp-content/themes/twentyfourteen/content-gallery.php

@@ -25 +25 @@
 
 <article id="post-<?php the_ID(); ?>" <?php post_class(); ?>>
         <?php if( is_single() && $image ) : ?>
-        <div class="attachment-featured-thumbnail">
+        <div class="featured-thumbnail">
                 <?php echo wp_get_attachment_image( $image, 'featured-thumbnail-large' ); ?>
         </div>
         <?php elseif ( $image ) : ?>
-        <a class="attachment-featured-thumbnail" href="<?php the_permalink(); ?>" rel="<?php the_ID(); ?>">
+        <a class="featured-thumbnail" href="<?php the_permalink(); ?>" rel="<?php the_ID(); ?>">
                 <?php echo wp_get_attachment_image( $image, 'featured-thumbnail-large' ); ?>
         </a>
         <?php endif; ?>

wp-content/themes/twentyfourteen/inc/template-tags.php

@@ -143 +143 @@
 add_action( 'save_post',     'twentyfourteen_category_transient_flusher' );
 
 /**
- * Displays featured image with appropriate html tag.
+ * Displays an optional featured image, with an anchor element
+ * when on index views, and a div element when on a single view.
  *
  * @return void
  */
 function twentyfourteen_featured_thumbnail() {
-        if ( ! post_password_required() ) :
-                if ( has_post_thumbnail() && is_singular() ) :
-                ?>
-                        <div class="attachment-featured-thumbnail">
-                                <?php the_post_thumbnail( 'featured-thumbnail-large' ); ?>
-                        </div>
-                <?php
-                else :
-                ?>
-                        <a href="<?php the_permalink(); ?>" rel="<?php the_ID(); ?>" class="attachment-featured-thumbnail">
-                                <?php the_post_thumbnail( 'featured-thumbnail-large' ); ?>
-                        </a>
-                <?php
-                endif;
-        endif;
+        if ( post_password_required() )
+                return;
+
+        if ( is_singular() ) {
+                printf( '<div class="featured-thumbnail">' );
+        } else {
+                printf( '<a href="%s" rel="%s" class="featured-thumbnail">', esc_url( get_permalink() ), esc_attr( get_the_ID() ) );
+        }
+                // Avoid an empty element for better accessibility.
+                if ( has_post_thumbnail() ) {
+                        the_post_thumbnail( 'featured-thumbnail-large' );
+                } else {
+                        printf( '<p class="screen-reader-text">%s</p>', __( 'No featured image', 'twentyfourteen' ) );
+                }
+        if ( is_singular() ) {
+                printf( '</div>');
+        } else {
+                printf( '</a>' );
+        }
 }
+ No newline at end of file

wp-content/themes/twentyfourteen/rtl.css

@@ -350 +350 @@
 
 /* Mobile list style */
 @media screen and (max-width: 400px) {
-        .list-view .attachment-featured-thumbnail img {
+        .list-view .featured-thumbnail img {
                 float: right;
                 margin: 0 0 3px 10px;
         }

wp-content/themes/twentyfourteen/style.css

@@ -802 +802 @@
         margin-bottom: 24px;
         max-width: 672px;
 }
-.attachment-featured-thumbnail {
+.featured-thumbnail {
         background: #767676;
         background-attachment: fixed;
         background-image: -webkit-linear-gradient(135deg, #767676 12.5%, #fff 12.5%, #fff 50%, #767676 50%, #767676 62.5%, #fff 62.5%);
@@ -817 +817 @@
         height: auto;
         z-index: 0;
 }
-.has-featured-image .attachment-featured-thumbnail,
-.format-standard .attachment-featured-thumbnail {
+.has-featured-image .featured-thumbnail,
+.format-standard .featured-thumbnail {
         display: block;
 }
-.attachment-featured-thumbnail:hover {
+.featured-thumbnail:hover {
         background: #919191;
         background-attachment: fixed;
         background-image: -webkit-linear-gradient(135deg, #919191 12.5%, #fff 12.5%, #fff 50%, #919191 50%, #919191 62.5%, #fff 62.5%);
@@ -828 +828 @@
         background-image:         linear-gradient(135deg, #919191 12.5%, #fff 12.5%, #fff 50%, #919191 50%, #919191 62.5%, #fff 62.5%);
         background-size: 4px 4px;
 }
-.attachment-featured-thumbnail img {
+.featured-thumbnail img {
         display: block;
         margin: 0 auto;
 }
@@ -1372 +1372 @@
         height: auto;
 }
 .attachment-featured-featured img,
-.attachment-featured-thumbnail img {
+.featured-thumbnail img {
         height: auto;
         max-width: 100%;
 }
@@ -2152 +2152 @@
         .list-view .content-area footer.entry-meta {
                 display: none;
         }
-        .list-view .attachment-featured-thumbnail {
+        .list-view .featured-thumbnail {
                 background: none;
                 min-height: 0;
                 width: auto;
                 z-index: 2;
         }
-        .list-view .attachment-featured-thumbnail img {
+        .list-view .featured-thumbnail img {
                 float: left;
                 margin: 0 10px 3px 0;
                 width: 84px;
@@ -2197 +2197 @@
 }
 
 @media screen and (min-width: 401px) {
-        a.attachment-featured-thumbnail:hover img {
+        a.featured-thumbnail:hover img {
                 opacity: 0.85;
         }
         .content-area span + .entry-date:before,
@@ -2284 +2284 @@
                 border-top: 1px solid rgba(0, 0, 0, 0.1);
                 padding-top: 48px;
         }
-        .list-view .content-area .has-featured-image .attachment-featured-thumbnail,
-        .list-view .content-area .format-standard .attachment-featured-thumbnail {
+        .list-view .content-area .has-featured-image .featured-thumbnail,
+        .list-view .content-area .format-standard .featured-thumbnail {
                 margin-top: -49px;
         }
 }