WordPress.org

Make WordPress Core

Ticket #25325: 25325.6.diff

File 25325.6.diff, 5.5 KB (added by lancewillett, 8 years ago)

Better logic for HTML output and add fallback screen-reader-text message

  • wp-content/themes/twentyfourteen/content-gallery.php

     
    2525
    2626<article id="post-<?php the_ID(); ?>" <?php post_class(); ?>>
    2727        <?php if( is_single() && $image ) : ?>
    28         <div class="attachment-featured-thumbnail">
     28        <div class="featured-thumbnail">
    2929                <?php echo wp_get_attachment_image( $image, 'featured-thumbnail-large' ); ?>
    3030        </div>
    3131        <?php elseif ( $image ) : ?>
    32         <a class="attachment-featured-thumbnail" href="<?php the_permalink(); ?>" rel="<?php the_ID(); ?>">
     32        <a class="featured-thumbnail" href="<?php the_permalink(); ?>" rel="<?php the_ID(); ?>">
    3333                <?php echo wp_get_attachment_image( $image, 'featured-thumbnail-large' ); ?>
    3434        </a>
    3535        <?php endif; ?>
  • wp-content/themes/twentyfourteen/inc/template-tags.php

     
    143143add_action( 'save_post',     'twentyfourteen_category_transient_flusher' );
    144144
    145145/**
    146  * Displays featured image with appropriate html tag.
     146 * Displays an optional featured image, with an anchor element
     147 * when on index views, and a div element when on a single view.
    147148 *
    148149 * @return void
    149150 */
    150151function twentyfourteen_featured_thumbnail() {
    151         if ( ! post_password_required() ) :
    152                 if ( has_post_thumbnail() && is_singular() ) :
    153                 ?>
    154                         <div class="attachment-featured-thumbnail">
    155                                 <?php the_post_thumbnail( 'featured-thumbnail-large' ); ?>
    156                         </div>
    157                 <?php
    158                 else :
    159                 ?>
    160                         <a href="<?php the_permalink(); ?>" rel="<?php the_ID(); ?>" class="attachment-featured-thumbnail">
    161                                 <?php the_post_thumbnail( 'featured-thumbnail-large' ); ?>
    162                         </a>
    163                 <?php
    164                 endif;
    165         endif;
     152        if ( post_password_required() )
     153                return;
     154
     155        if ( is_singular() ) {
     156                printf( '<div class="featured-thumbnail">' );
     157        } else {
     158                printf( '<a href="%s" rel="%s" class="featured-thumbnail">', esc_url( get_permalink() ), esc_attr( get_the_ID() ) );
     159        }
     160                // Avoid an empty element for better accessibility.
     161                if ( has_post_thumbnail() ) {
     162                        the_post_thumbnail( 'featured-thumbnail-large' );
     163                } else {
     164                        printf( '<p class="screen-reader-text">%s</p>', __( 'No featured image', 'twentyfourteen' ) );
     165                }
     166        if ( is_singular() ) {
     167                printf( '</div>');
     168        } else {
     169                printf( '</a>' );
     170        }
    166171}
     172 No newline at end of file
  • wp-content/themes/twentyfourteen/rtl.css

     
    350350
    351351/* Mobile list style */
    352352@media screen and (max-width: 400px) {
    353         .list-view .attachment-featured-thumbnail img {
     353        .list-view .featured-thumbnail img {
    354354                float: right;
    355355                margin: 0 0 3px 10px;
    356356        }
  • wp-content/themes/twentyfourteen/style.css

     
    802802        margin-bottom: 24px;
    803803        max-width: 672px;
    804804}
    805 .attachment-featured-thumbnail {
     805.featured-thumbnail {
    806806        background: #767676;
    807807        background-attachment: fixed;
    808808        background-image: -webkit-linear-gradient(135deg, #767676 12.5%, #fff 12.5%, #fff 50%, #767676 50%, #767676 62.5%, #fff 62.5%);
     
    817817        height: auto;
    818818        z-index: 0;
    819819}
    820 .has-featured-image .attachment-featured-thumbnail,
    821 .format-standard .attachment-featured-thumbnail {
     820.has-featured-image .featured-thumbnail,
     821.format-standard .featured-thumbnail {
    822822        display: block;
    823823}
    824 .attachment-featured-thumbnail:hover {
     824.featured-thumbnail:hover {
    825825        background: #919191;
    826826        background-attachment: fixed;
    827827        background-image: -webkit-linear-gradient(135deg, #919191 12.5%, #fff 12.5%, #fff 50%, #919191 50%, #919191 62.5%, #fff 62.5%);
     
    828828        background-image:         linear-gradient(135deg, #919191 12.5%, #fff 12.5%, #fff 50%, #919191 50%, #919191 62.5%, #fff 62.5%);
    829829        background-size: 4px 4px;
    830830}
    831 .attachment-featured-thumbnail img {
     831.featured-thumbnail img {
    832832        display: block;
    833833        margin: 0 auto;
    834834}
     
    13721372        height: auto;
    13731373}
    13741374.attachment-featured-featured img,
    1375 .attachment-featured-thumbnail img {
     1375.featured-thumbnail img {
    13761376        height: auto;
    13771377        max-width: 100%;
    13781378}
     
    21522152        .list-view .content-area footer.entry-meta {
    21532153                display: none;
    21542154        }
    2155         .list-view .attachment-featured-thumbnail {
     2155        .list-view .featured-thumbnail {
    21562156                background: none;
    21572157                min-height: 0;
    21582158                width: auto;
    21592159                z-index: 2;
    21602160        }
    2161         .list-view .attachment-featured-thumbnail img {
     2161        .list-view .featured-thumbnail img {
    21622162                float: left;
    21632163                margin: 0 10px 3px 0;
    21642164                width: 84px;
     
    21972197}
    21982198
    21992199@media screen and (min-width: 401px) {
    2200         a.attachment-featured-thumbnail:hover img {
     2200        a.featured-thumbnail:hover img {
    22012201                opacity: 0.85;
    22022202        }
    22032203        .content-area span + .entry-date:before,
     
    22842284                border-top: 1px solid rgba(0, 0, 0, 0.1);
    22852285                padding-top: 48px;
    22862286        }
    2287         .list-view .content-area .has-featured-image .attachment-featured-thumbnail,
    2288         .list-view .content-area .format-standard .attachment-featured-thumbnail {
     2287        .list-view .content-area .has-featured-image .featured-thumbnail,
     2288        .list-view .content-area .format-standard .featured-thumbnail {
    22892289                margin-top: -49px;
    22902290        }
    22912291}