Make WordPress Core

Ticket #25699: 25699.3.patch

File 25699.3.patch, 7.3 KB (added by markjaquith, 11 years ago)

some cleanup

  • src/wp-includes/comment.php

     
    13761376 * that it is properly set, such as in wp-config.php, for your environment.
    13771377 * See {@link http://core.trac.wordpress.org/ticket/9235}
    13781378 *
    1379  * @since 1.5.0
    1380  * @uses apply_filters() Calls 'preprocess_comment' hook on $commentdata parameter array before processing
    1381  * @uses do_action() Calls 'comment_post' hook on $comment_ID returned from adding the comment and if the comment was approved.
    1382  * @uses wp_filter_comment() Used to filter comment before adding comment.
    1383  * @uses wp_allow_comment() checks to see if comment is approved.
    1384  * @uses wp_insert_comment() Does the actual comment insertion to the database.
    1385  *
    1386  * @param array $commentdata Contains information on the comment.
    1387  * @return int The ID of the comment after adding.
     1379 * @since  1.5.0
     1380 * @param  array $commentdata Contains information on the comment.
     1381 * @uses   apply_filters
     1382 * @uses   wp_get_comment_status
     1383 * @uses   wp_filter_comment
     1384 * @uses   wp_allow_comment
     1385 * @uses   wp_insert_comment
     1386 * @uses   do_action
     1387 * @uses   wp_notify_moderator
     1388 * @uses   get_option
     1389 * @uses   wp_notify_postauthor
     1390 * @return int                The ID of the comment after adding.
    13881391 */
    13891392function wp_new_comment( $commentdata ) {
    13901393        $commentdata = apply_filters('preprocess_comment', $commentdata);
     
    14171420                if ( '0' == $commentdata['comment_approved'] )
    14181421                        wp_notify_moderator($comment_ID);
    14191422
    1420                 $post = get_post($commentdata['comment_post_ID']); // Don't notify if it's your own comment
    1421 
    1422                 if ( get_option('comments_notify') && $commentdata['comment_approved'] && ( ! isset( $commentdata['user_id'] ) || $post->post_author != $commentdata['user_id'] ) )
    1423                         wp_notify_postauthor($comment_ID, isset( $commentdata['comment_type'] ) ? $commentdata['comment_type'] : '' );
     1423                // wp_notify_postauthor() checks if notifying the author of his/her own comment.
     1424                // By default, it won't, but filters can override this.
     1425                if ( get_option( 'comments_notify' ) && $commentdata['comment_approved'] )
     1426                        wp_notify_postauthor( $comment_ID, isset( $commentdata['comment_type'] ) ? $commentdata['comment_type'] : '' );
    14241427        }
    14251428
    14261429        return $comment_ID;
  • src/wp-includes/pluggable.php

     
    10001000
    10011001if ( ! function_exists('wp_notify_postauthor') ) :
    10021002/**
    1003  * Notify an author of a comment/trackback/pingback to one of their posts.
     1003 * Notify an author (and/or others) of a comment/trackback/pingback on a post.
    10041004 *
    10051005 * @since 1.0.0
    10061006 *
    1007  * @param int $comment_id Comment ID
    1008  * @param string $comment_type Optional. The comment type either 'comment' (default), 'trackback', or 'pingback'
    1009  * @return bool False if user email does not exist. True on completion.
     1007 * @param  int $comment_id      Comment ID
     1008 * @param  string $comment_type Optional. The comment type either 'comment' (default), 'trackback', or 'pingback'
     1009 * @uses   get_comment
     1010 * @uses   get_post
     1011 * @uses   get_userdata
     1012 * @uses   apply_filters
     1013 * @uses   wp_specialchars_decode
     1014 * @uses   get_option
     1015 * @uses   __
     1016 * @uses   get_permalink
     1017 * @uses   admin_url
     1018 * @uses   wp_mail
     1019 * @return bool                 True on completion. False if no email addresses were specified.
    10101020 */
    10111021function wp_notify_postauthor( $comment_id, $comment_type = '' ) {
    10121022        $comment = get_comment( $comment_id );
     
    10161026        $post    = get_post( $comment->comment_post_ID );
    10171027        $author  = get_userdata( $post->post_author );
    10181028
    1019         // The comment was left by the author
    1020         if ( $comment->user_id == $post->post_author )
     1029        // Who to notify? By default, just the post author, but others can be added.
     1030        $emails = array( $author->user_email );
     1031        $emails = apply_filters( 'comment_notification_recipients', $emails, $comment_id );
     1032        $emails = array_filter( $emails );
     1033
     1034        // If there are no addresses to send the comment to, bail.
     1035        if ( ! count( $emails ) ) {
    10211036                return false;
     1037        }
    10221038
     1039        // Facilitate unsetting below without knowing the keys.
     1040        $emails = array_flip( $emails );
     1041
     1042        // Post author may want to receive notifications for their own comments
     1043        $notify_author = apply_filters( 'comment_notification_notify_author', false, $comment_id );
     1044
     1045        // The comment was left by the author
     1046        if ( ! $notify_author && $comment->user_id == $post->post_author ) {
     1047                unset( $emails[ $author->user_email ] );
     1048        }
     1049
    10231050        // The author moderated a comment on his own post
    1024         if ( $post->post_author == get_current_user_id() )
    1025                 return false;
     1051        if ( ! $notify_author && $post->post_author == get_current_user_id() ) {
     1052                unset( $emails[ $author->user_email ] );
     1053        }
    10261054
    10271055        // The post author is no longer a member of the blog
    1028         if ( ! user_can( $post->post_author, 'read_post', $post->ID ) )
    1029                 return false;
     1056        if ( ! $notify_author && ! user_can( $post->post_author, 'read_post', $post->ID ) ) {
     1057                unset( $emails[ $author->user_email ] );
     1058        }
    10301059
    1031         // If there's no email to send the comment to
    1032         if ( '' == $author->user_email )
     1060        // If there's no email to send the comment to, bail, otherwise flip array back around for use below
     1061        if ( ! count( $emails ) ) {
    10331062                return false;
     1063        } else {
     1064                $emails = array_flip( $emails );
     1065        }
    10341066
    10351067        $comment_author_domain = @gethostbyaddr($comment->comment_author_IP);
    10361068
     
    10381070        // we want to reverse this for the plain text arena of emails.
    10391071        $blogname = wp_specialchars_decode(get_option('blogname'), ENT_QUOTES);
    10401072
    1041         if ( empty( $comment_type ) ) $comment_type = 'comment';
     1073        if ( empty( $comment_type ) ) {
     1074                $comment_type = 'comment';
     1075        }
    10421076
    10431077        switch ( $comment_type ) {
    10441078                case 'trackback':
     
    10821116                        $notify_message .= sprintf( __('Trash it: %s'), admin_url("comment.php?action=trash&c=$comment_id") ) . "\r\n";
    10831117                else
    10841118                        $notify_message .= sprintf( __('Delete it: %s'), admin_url("comment.php?action=delete&c=$comment_id") ) . "\r\n";
     1119
    10851120                $notify_message .= sprintf( __('Spam it: %s'), admin_url("comment.php?action=spam&c=$comment_id") ) . "\r\n";
    10861121        }
    10871122
     
    10891124
    10901125        if ( '' == $comment->comment_author ) {
    10911126                $from = "From: \"$blogname\" <$wp_email>";
    1092                 if ( '' != $comment->comment_author_email )
     1127                if ( '' != $comment->comment_author_email ) {
    10931128                        $reply_to = "Reply-To: $comment->comment_author_email";
     1129                }
    10941130        } else {
    10951131                $from = "From: \"$comment->comment_author\" <$wp_email>";
    1096                 if ( '' != $comment->comment_author_email )
     1132                if ( '' != $comment->comment_author_email ) {
    10971133                        $reply_to = "Reply-To: \"$comment->comment_author_email\" <$comment->comment_author_email>";
     1134                }
    10981135        }
    10991136
    11001137        $message_headers = "$from\n"
    11011138                . "Content-Type: text/plain; charset=\"" . get_option('blog_charset') . "\"\n";
    11021139
    1103         if ( isset($reply_to) )
     1140        if ( isset( $reply_to ) ) {
    11041141                $message_headers .= $reply_to . "\n";
     1142        }
    11051143
    1106         $emails = array( $author->user_email );
    1107 
    1108         $emails          = apply_filters( 'comment_notification_recipients', $emails,          $comment_id );
    11091144        $notify_message  = apply_filters( 'comment_notification_text',       $notify_message,  $comment_id );
    11101145        $subject         = apply_filters( 'comment_notification_subject',    $subject,         $comment_id );
    11111146        $message_headers = apply_filters( 'comment_notification_headers',    $message_headers, $comment_id );