Ticket #26948: 26948.diff

src/wp-admin/includes/class-wp-posts-list-table.php

@@ -944 +944 @@
                 $hierarchical_taxonomies = array();
                 $flat_taxonomies = array();
                 foreach ( $taxonomy_names as $taxonomy_name ) {
+
+                        /**
+                         * Filters whether the current taxonomy should be shown in the Quick Edit panel.
+                         *
+                         * @since 4.2.0
+                         *
+                         * @param bool   $value         Whether to display the current taxonomy in Quick Edit.
+                         *                              Default: true.
+                         * @param string $taxonomy_name Taxonomy name.
+                         * @param string $post_type     Post type of current Quick Edit post.
+                         */
+                        if ( ! apply_filters( 'quick_edit_show_taxonomy', true, $taxonomy_name, $screen->post_type ) ) {
+                                continue;
+                        }
+
                         $taxonomy = get_taxonomy( $taxonomy_name );
 
-                        if ( !$taxonomy->show_ui )
+                        if ( ! $taxonomy->show_in_quick_edit ) {
                                 continue;
+                        }
 
                         if ( $taxonomy->hierarchical )
                                 $hierarchical_taxonomies[] = $taxonomy;

src/wp-includes/taxonomy.php

@@ -282 +282 @@
  *     * If not set, the default is inherited from public.
  * - show_tagcloud - Whether to list the taxonomy in the Tag Cloud Widget.
  *     * If not set, the default is inherited from show_ui.
+ * - show_in_quick_edit - Whether to show the taxonomy in the quick/bulk edit panel.
+ *     * It not set, the default is inherited from show_ui.
  * - show_admin_column - Whether to display a column for the taxonomy on its post type listing screens.
  *     * Defaults to false.
  * - meta_box_cb - Provide a callback function for the meta box display.
@@ -331 +333 @@
                 'show_in_menu'          => null,
                 'show_in_nav_menus'     => null,
                 'show_tagcloud'         => null,
+                'show_in_quick_edit'    => null,
                 'show_admin_column'     => false,
                 'meta_box_cb'           => null,
                 'capabilities'          => array(),
@@ -389 +392 @@
         if ( null === $args['show_tagcloud'] )
                 $args['show_tagcloud'] = $args['show_ui'];
 
+        // If not set, default to the setting for show_ui.
+        if ( null === $args['show_in_quick_edit'] ) {
+                $args['show_in_quick_edit'] = $args['show_ui'];
+        }
+
         $default_caps = array(
                 'manage_terms' => 'manage_categories',
                 'edit_terms'   => 'manage_categories',

tests/phpunit/tests/taxonomy.php

@@ -163 +163 @@
         }
 
         /**
+         * @ticket 26948
+         */
+        public function test_register_taxonomy_show_in_quick_edit_should_default_to_value_of_show_ui() {
+                register_taxonomy( 'wptests_tax_1', 'post', array(
+                        'show_ui' => true,
+                ) );
+
+                register_taxonomy( 'wptests_tax_2', 'post', array(
+                        'show_ui' => false,
+                ) );
+
+                $tax_1 = get_taxonomy( 'wptests_tax_1' );
+                $this->assertTrue( $tax_1->show_in_quick_edit );
+
+                $tax_2 = get_taxonomy( 'wptests_tax_2' );
+                $this->assertFalse( $tax_2->show_in_quick_edit );
+        }
+
+        /**
          * @ticket 11058
          */
         function test_registering_taxonomies_to_object_types() {