Ticket #27887: 27887.patch

src/wp-includes/user.php

@@ -521 +521 @@
          *     @type array        $search_columns  Array of column names to be searched. Accepts 'ID', 'login',
          *                                         'nicename', 'email', 'url'. Default empty array.
          *     @type string       $orderby         Field to sort the retrieved users by. Accepts 'ID', 'display_name',
-         *                                         'login', 'nicename', 'email', 'url', 'registered', 'post_count', or
-         *                                         'meta_value'. To use 'meta_value', `$meta_key` must be also be defined.
+         *                                         'login', 'nicename', 'email', 'url', 'registered', 'post_count',
+         *                                         'meta_value' or 'meta_value_num'. To use 'meta_value' or 
+         *                                         'meta_value_num', `$meta_key` must be also be defined.
          *                                         Default 'user_login'.
          *     @type string       $order           Designates ascending or descending order of users. Accepts 'ASC',
          *                                         'DESC'. Default 'ASC'.
@@ -631 +632 @@
                                 $orderby = 'ID';
                         } elseif ( 'meta_value' == $qv['orderby'] ) {
                                 $orderby = "$wpdb->usermeta.meta_value";
+                        } elseif ( 'meta_value_num' == $qv['orderby'] ) {
+                                $orderby = "$wpdb->usermeta.meta_value+0";
                         } elseif ( 'include' === $qv['orderby'] && ! empty( $include ) ) {
                                 // Sanitized earlier.
                                 $include_sql = implode( ',', $include );

tests/phpunit/tests/user/query.php

@@ -186 +186 @@
         }
 
         /**
+         * @ticket 27887
+         */
+        public function test_orderby_meta_value_num() {
+                $users = $this->factory->user->create_many( 3, array(
+                        'role' => 'author'
+                ) );
+
+                update_user_meta( $users[0], 'user_age', '101' );
+                update_user_meta( $users[1], 'user_age', '20' );
+                update_user_meta( $users[2], 'user_age', '25' );
+
+                $q = new WP_User_Query( array(
+                        'include' => $users,
+                        'meta_key' => 'user_age',
+                        'orderby' => 'meta_value_num',
+                        'fields' => 'ids'
+                ) );
+
+                $expected = array( $users[1], $users[2], $users[0] );
+
+                $this->assertEquals( $expected, $q->get_results() );
+        }
+
+        /**
          * @ticket 21119
          */
         function test_prepare_query() {