Ticket #28145: 28145.3.diff

src/wp-admin/includes/template.php

@@ -134 +134 @@
                 ) );
         }
         if ( $descendants_and_self ) {
-                $categories = (array) get_terms( $taxonomy, array(
-                        'child_of' => $descendants_and_self,
-                        'hierarchical' => 0,
-                        'hide_empty' => 0
-                ) );
+                if( is_taxonomy_hierarchical( $taxonomy ) ) {
+                        $categories = (array) get_terms( $taxonomy, array( 'child_of' => $descendants_and_self, 'hierarchical' => 0, 'hide_empty' => 0 ) );
+                } else {
+                        $categories = array();
+                }
                 $self = get_term( $descendants_and_self, $taxonomy );
                 array_unshift( $categories, $self );
         } else {

tests/phpunit/tests/admin/includesTemplate.php

@@ -3 +3 @@
  * @group admin
  */
 class Tests_Admin_includesTemplate extends WP_UnitTestCase {
+
+        function setUp() {
+                parent::setUp();
+
+                register_taxonomy( 'testing-non-slug', array( 'post' ), array( 'labels' => array( 'name' => 'testing-non' ) ) );
+                $this->non_id = wp_insert_term( 'testnon1', 'testing-non-slug' );
+                wp_insert_term( 'testnon2', 'testing-non-slug' );
+                wp_insert_term( 'testnon3', 'testing-non-slug' );
+                wp_insert_term( 'testnon4', 'testing-non-slug' );
+
+                register_taxonomy( 'testing-h-slug', array( 'post' ), array( 'labels' => array( 'name' => 'testing-h', 'hierarchal' => true ) ) );
+                $this->parent_id = wp_insert_term( 'testh1', 'testing-h-slug' );
+                wp_insert_term( 'testh2', 'testing-h-slug', array( 'parent' => $this->parent_id['term_id'] ) );
+                wp_insert_term( 'testh3', 'testing-h-slug', array( 'parent' => $this->parent_id['term_id'] ) );
+                wp_insert_term( 'testh4', 'testing-h-slug', array( 'parent' => $this->parent_id['term_id'] ) );
+        }
+
         function test_equal() {
                 $this->assertEquals(' selected=\'selected\'', selected('foo','foo',false));
                 $this->assertEquals(' checked=\'checked\'', checked('foo','foo',false));
@@ -108 +125 @@
                 $this->assertFalse( $wp_meta_boxes['attachment']['advanced']['default']['testbox1'] );
         }
 
+        function test_wp_terms_checklist_decendants_and_self() {
+                ob_start();
+                wp_terms_checklist( 0, array( 'decendants_and_self' => 1 ) );
+                $actual = ob_get_clean();
+                $expected = "\n<li id='category-1'><label class=\"selectit\"><input value=\"1\" type=\"checkbox\" name=\"post_category[]\" id=\"in-category-1\" disabled='disabled' /> Uncategorized</label></li>\n";
+                $this->assertSame( $actual, $expected );
+        }
+
+        function test_wp_terms_checklist_decendants_and_self_non_hierarchal() {
+                ob_start();
+                wp_terms_checklist( 0, array( 'decendants_and_self' => $this->non_id, 'taxonomy' => 'testing-non-slug' ) );
+                $actual = ob_get_clean();
+                $expected = "\n" . '<li id=\'testing-non-slug-62\'><label class="selectit"><input value="62" type="checkbox" name="tax_input[testing-non-slug][]" id="in-testing-non-slug-62" disabled=\'disabled\' /> testnon1</label></li>
+
+<li id=\'testing-non-slug-63\'><label class="selectit"><input value="63" type="checkbox" name="tax_input[testing-non-slug][]" id="in-testing-non-slug-63" disabled=\'disabled\' /> testnon2</label></li>
+
+<li id=\'testing-non-slug-64\'><label class="selectit"><input value="64" type="checkbox" name="tax_input[testing-non-slug][]" id="in-testing-non-slug-64" disabled=\'disabled\' /> testnon3</label></li>
+
+<li id=\'testing-non-slug-65\'><label class="selectit"><input value="65" type="checkbox" name="tax_input[testing-non-slug][]" id="in-testing-non-slug-65" disabled=\'disabled\' /> testnon4</label></li>' . "\n";
+                $this->assertSame( $actual, $expected );
+        }
+
+        function test_wp_terms_checklist_decendants_and_self_hierarchal() {
+                ob_start();
+                wp_terms_checklist( 0, array( 'decendants_and_self' => $this->parent_id['term_id'], 'taxonomy' => 'testing-h-slug' ) );
+                $actual = ob_get_clean();
+                $expected = "\n" . '<li id=\'testing-h-slug-74\'><label class="selectit"><input value="74" type="checkbox" name="tax_input[testing-h-slug][]" id="in-testing-h-slug-74" disabled=\'disabled\' /> testh1</label><ul class=\'children\'>
+
+<li id=\'testing-h-slug-75\'><label class="selectit"><input value="75" type="checkbox" name="tax_input[testing-h-slug][]" id="in-testing-h-slug-75" disabled=\'disabled\' /> testh2</label></li>
+
+<li id=\'testing-h-slug-76\'><label class="selectit"><input value="76" type="checkbox" name="tax_input[testing-h-slug][]" id="in-testing-h-slug-76" disabled=\'disabled\' /> testh3</label></li>
+
+<li id=\'testing-h-slug-77\'><label class="selectit"><input value="77" type="checkbox" name="tax_input[testing-h-slug][]" id="in-testing-h-slug-77" disabled=\'disabled\' /> testh4</label></li>
+</ul>
+</li>' . "\n";
+                $this->assertSame( $actual, $expected );
+        }
+
 }