Ticket #28709: 28709.13.diff

src/wp-admin/js/customize-controls.js

@@ -142 +142 @@
                         container.container = $( container.params.content );
 
                         container.deferred = {
-                                ready: new $.Deferred()
+                                embedded: new $.Deferred()
                         };
                         container.priority = new api.Value();
                         container.active = new api.Value();
@@ -155 +155 @@
                                 args = $.extend( {}, container.defaultActiveArguments, args );
                                 active = ( active && container.isContextuallyActive() );
                                 container.onChangeActive( active, args );
-                                // @todo trigger 'activated' and 'deactivated' events based on the expanded param?
                         });
                         container.expanded.bind( function ( expanded ) {
                                 var args = container.expandedArgumentsQueue.shift();
                                 args = $.extend( {}, container.defaultExpandedArguments, args );
                                 container.onChangeExpanded( expanded, args );
-                                // @todo trigger 'expanded' and 'collapsed' events based on the expanded param?
                         });
 
                         container.attachEvents();
@@ -170 +168 @@
 
                         container.priority.set( isNaN( container.params.priority ) ? 100 : container.params.priority );
                         container.active.set( container.params.active );
-                        container.expanded.set( false ); // @todo True if deeplinking?
+                        container.expanded.set( false );
                 },
 
                 /**
@@ -338 +336 @@
                         bubbleChildValueChanges( section, [ 'panel' ] );
 
                         section.embed();
-                        section.deferred.ready.done( function () {
+                        section.deferred.embedded.done( function () {
                                 section.ready();
                         });
                 },
@@ -356 +354 @@
                                         // The panel has been supplied, so wait until the panel object is registered
                                         api.panel( panelId, function ( panel ) {
                                                 // The panel has been registered, wait for it to become ready/initialized
-                                                panel.deferred.ready.done( function () {
+                                                panel.deferred.embedded.done( function () {
                                                         parentContainer = panel.container.find( 'ul:first' );
                                                         if ( ! section.container.parent().is( parentContainer ) ) {
                                                                 parentContainer.append( section.container );
                                                         }
-                                                        section.deferred.ready.resolve(); // @todo Better to use `embedded` instead of `ready`
+                                                        section.deferred.embedded.resolve();
                                                 });
                                         } );
                                 } else {
@@ -370 +368 @@
                                         if ( ! section.container.parent().is( parentContainer ) ) {
                                                 parentContainer.append( section.container );
                                         }
-                                        section.deferred.ready.resolve();
+                                        section.deferred.embedded.resolve();
                                 }
                         };
                         section.panel.bind( inject );
@@ -479 +477 @@
                         var panel = this;
                         Container.prototype.initialize.call( panel, id, options );
                         panel.embed();
-                        panel.deferred.ready.done( function () {
+                        panel.deferred.embedded.done( function () {
                                 panel.ready();
                         });
                 },
@@ -494 +492 @@
                         if ( ! panel.container.parent().is( parentContainer ) ) {
                                 parentContainer.append( panel.container );
                         }
-                        panel.deferred.ready.resolve();
+                        panel.deferred.embedded.resolve();
                 },
 
                 /**
@@ -676 +674 @@
                         control.container = control.params.content ? $( control.params.content ) : $( control.selector );
 
                         control.deferred = {
-                                ready: new $.Deferred()
+                                embedded: new $.Deferred()
                         };
                         control.section = new api.Value();
                         control.priority = new api.Value();
@@ -739 +737 @@
                                 control.embed();
                         }) );
 
-                        control.deferred.ready.done( function () {
+                        control.deferred.embedded.done( function () {
                                 control.ready();
                         });
                 },
@@ -760 +758 @@
                                 // Wait for the section to be registered
                                 api.section( sectionId, function ( section ) {
                                         // Wait for the section to be ready/initialized
-                                        section.deferred.ready.done( function () {
+                                        section.deferred.embedded.done( function () {
                                                 parentContainer = section.container.find( 'ul:first' );
                                                 if ( ! control.container.parent().is( parentContainer ) ) {
                                                         parentContainer.append( control.container );
                                                         control.renderContent();
                                                 }
-                                                control.deferred.ready.resolve(); // @todo Better to use `embedded` instead of `ready`
+                                                control.deferred.embedded.resolve();
                                         });
                                 });
                         };
@@ -1930 +1928 @@
                         if ( id && api[ type ]( id ) ) {
                                 instance = api[ type ]( id );
                                 // Wait until the element is embedded in the DOM
-                                instance.deferred.ready.done( function () {
+                                instance.deferred.embedded.done( function () {
                                         // Wait until the preview has activated and so active panels, sections, controls have been set
                                         api.previewer.deferred.active.done( function () {
                                                 instance.focus();