Ticket #28785: 28785.patch

src/wp-admin/includes/class-wp-plugin-install-list-table.php

@@ -279 +279 @@
                         $details_link   = self_admin_url( 'plugin-install.php?tab=plugin-information&plugin=' . $plugin['slug'] .
                                                                 '&TB_iframe=true&width=600&height=550' );
 
-                        $action_links[] = '<a href="' . esc_attr( $details_link ) . '" class="thickbox" title="' .
+                        $action_links[] = '<a href="' . esc_url( $details_link ) . '" class="thickbox" title="' .
                                                                 esc_attr( sprintf( __( 'More information about %s' ), $name ) ) . '">' . __( 'More Details' ) . '</a>';
 
                         /**
@@ -295 +295 @@
                 <div class="plugin-card">
                         <div class="plugin-card-top">
                                 <div class="name column-name"<?php echo $style['name']; ?>>
-                                        <h4><a href="<?php echo esc_attr( $details_link ) ?>" class="thickbox"><?php echo $title; ?></a></h4>
+                                        <h4><a href="<?php echo esc_url( $details_link ) ?>" class="thickbox"><?php echo $title; ?></a></h4>
                                         <div class="action-links">
                                                 <?php
                                                         if ( ! empty( $action_links ) ) {
@@ -317 +317 @@
                                         <?php wp_star_rating( array( 'rating' => $plugin['rating'], 'type' => 'percent', 'number' => $plugin['num_ratings'] ) ); ?>
                                         <span class="num-ratings">(<?php echo number_format_i18n( $plugin['num_ratings'] ); ?>)</span>
                                 </div>
-                                <div class="column-updated"><?php echo __( '<strong>Last updated:</strong>' ) . ' '. sprintf( '%s ago', human_time_diff( strtotime($plugin['last_updated']) ) ); ?></div>
-                                <div class="column-downloaded"><?php echo sprintf( __('%s downloads'), number_format_i18n( $plugin['downloaded'] ) ); ?></div>
+                                <div class="column-updated">
+                                        <strong><?php _e( 'Last Updated:' ); ?></strong> <span title="<?php echo esc_attr( $plugin['last_updated'] ); ?>">
+                                                <?php printf( __( '%s ago' ), human_time_diff( strtotime( $plugin['last_updated'] ) ) ); ?>
+                                        </span>
+                                </div>
+                                <div class="column-downloaded">
+                                        <?php echo sprintf( _n( '%s download', '%s downloads', $plugin['downloaded'] ), number_format_i18n( $plugin['downloaded'] ) ); ?>
+                                </div>
                                 <div class="column-compatibility">
-                                <?php
+                                        <?php
                                         if ( ! empty( $plugin['tested'] ) && version_compare( substr( $GLOBALS['wp_version'], 0, strlen( $plugin['tested'] ) ), $plugin['tested'], '>' ) ) {
                                                 echo  __( '<strong>Untested</strong> with your install ');
                                         } elseif ( ! empty( $plugin['requires'] ) && version_compare( substr( $GLOBALS['wp_version'], 0, strlen( $plugin['requires'] ) ), $plugin['requires'], '<' ) ) {
@@ -328 +334 @@
                                         } else {
                                                 echo __( '<strong>Compatible</strong> with your install ');
                                         }
-                                ?>
+                                        ?>
                                 </div>
                         </div>
                 </div>