Ticket #29030: 29030.diff

src/js/_enqueues/admin/common.js

@@ -110 +110 @@
          * @returns {string} The hidden column names separated by a comma.
          */
         hidden : function() {
-                return $( '.manage-column[id]' ).filter( ':hidden' ).map(function() {
-                        return this.id;
+                //Checking for unchecked column names is better and more robust than checking for hidden column headers
+                return $( '.hide-column-tog' ).filter(':not(:checked)' ).map(function() {
+                        return this.value;
                 }).get().join( ',' );
         },
 

src/wp-admin/includes/ajax-actions.php

@@ -1573 +1573 @@
                 wp_die( -1 );
         }
 
+        $special = get_special_columns(); //get list of special columns that are not meant to be hidden
         $hidden = ! empty( $_POST['hidden'] ) ? explode( ',', $_POST['hidden'] ) : array();
+        $hidden = array_diff($hidden, $special); //remove the special columns from the list of columns to be hidden
         update_user_option( $user->ID, "manage{$page}columnshidden", $hidden, true );
 
         wp_die( 1 );

src/wp-admin/includes/class-wp-screen.php

@@ -1071 +1071 @@
                 <fieldset class="metabox-prefs">
                 <legend><?php echo $legend; ?></legend>
                 <?php
-                $special = array( '_title', 'cb', 'comment', 'media', 'name', 'title', 'username', 'blogname' );
+                $special = get_special_columns(); //get list of special columns that are not meant to be hidden
 
                 foreach ( $columns as $column => $title ) {
                         // Can't hide these for they are special

src/wp-admin/includes/screen.php

@@ -240 +240 @@
 function set_current_screen( $hook_name = '' ) {
         WP_Screen::get( $hook_name )->set_current_screen();
 }
+
+/**
+ * Get a list of special columns.
+ *
+ * @since X.Y.Z
+ *
+ * @return array
+ */
+function get_special_columns() {
+        $special = array( '_title', 'cb', 'comment', 'media', 'name', 'title', 'username', 'blogname' );
+
+        /**
+         * Filters the list of special columns.
+         *
+         * @since X.Y.Z
+         *
+         * @param array     $special An array of special columns.
+         */
+        return apply_filters( 'special_columns', $special );
+}