Ticket #29251: 29251.2.patch

src/wp-includes/link-template.php

@@ -909 +909 @@
 
         if ( $object_type ) {
                 $args['post_type'] = $object_type;
-        } else if ( ! empty( $tax->object_type ) ) {
-                $args['post_type'] = reset( $tax->object_type );
+        } elseif ( ! empty( $tax->object_type ) ) {
+                foreach ( $tax->object_type as $_object_type ) {
+                        if ( get_post_type_object( $_object_type ) ) {
+                                $args['post_type'] = $_object_type;
+                                break;
+                        }
+                }
         }
 
         $location = add_query_arg( $args, admin_url( 'edit-tags.php' ) );

new file tests/phpunit/tests/link/getEditTermLink.php

@@ +1 @@
+<?php
+
+/**
+ * @group link
+ * @group taxonomy
+ */
+class Tests_Link_GetEditTermLink extends WP_UnitTestCase {
+        private $current_user;
+
+        public function setUp() {
+                parent::setUp();
+                $this->current_user = get_current_user_id();
+                wp_set_current_user( $this->factory->user->create( array( 'role' => 'editor' ) ) );
+        }
+
+        public function tearDown() {
+                wp_set_current_user( $this->current_user );
+                parent::tearDown();
+        }
+
+        /**
+         * @ticket 29251
+         */
+        public function test_valid_object_type_should_be_inferred_when_none_is_specified_and_taxonomy_is_associated_with_a_post_type() {
+                register_post_type( 'wptests_pt' );
+                register_taxonomy( 'wptests_tax', 'wptests_pt' );
+                $t = $this->factory->term->create( array( 'taxonomy' => 'wptests_tax' ) );
+
+                $found = get_edit_term_link( $t, 'wptests_tax' );
+
+                $this->assertContains( 'post_type=wptests_pt', $found );
+        }
+
+        /**
+         * @ticket 29251
+         */
+        public function test_valid_object_type_should_be_inferred_when_none_is_specified_and_taxonomy_is_associated_with_non_post_type_as_well_as_post_type() {
+                register_post_type( 'wptests_pt' );
+                register_taxonomy( 'wptests_tax', array( 'foo', 'wptests_pt' ) );
+                $t = $this->factory->term->create( array( 'taxonomy' => 'wptests_tax' ) );
+
+                $found = get_edit_term_link( $t, 'wptests_tax' );
+
+                $this->assertContains( 'post_type=wptests_pt', $found );
+        }
+        /**
+         * @ticket 29251
+         */
+        public function test_object_type_should_not_be_inferred_when_taxonomy_is_associated_with_no_post_types() {
+                register_taxonomy( 'wptests_tax', 'foo' );
+                $t = $this->factory->term->create( array( 'taxonomy' => 'wptests_tax' ) );
+
+                $found = get_edit_term_link( $t, 'wptests_tax' );
+
+                $this->assertNotContains( 'post_type', $found );
+        }
+}