Ticket #29880: 29880.2.diff

src/wp-includes/user.php

@@ -1648 +1648 @@
  * @param array $userdata {
  *     An array, object, or WP_User object of user data arguments.
  *
- *     @type int         $ID              User ID. If supplied, the user will be updated.
+ *     @type int         $ID              User ID. If supplied, the user will be updated. This is
+ *                                        deprecated.
  *     @type string      $user_pass       The plain-text user password.
  *     @type string      $user_login      The user's login username.
  *     @type string      $user_nicename   The URL-friendly user name.
@@ -1683 +1684 @@
         }
         // Are we updating or creating?
         if ( ! empty( $userdata['ID'] ) ) {
+                _deprecated_argument( __FUNCTION__, '4.1', __( 'Supplying a user ID to wp_insert_user to update an existing user is deprecated. Use wp_update_user() instead.' ) );
                 $ID = (int) $userdata['ID'];
                 $update = true;
                 $old_user_data = WP_User::get_data_by( 'id', $ID );