Ticket #29880: 29880.3.patch

src/wp-includes/user-functions.php

@@ -1235 +1235 @@
  * @param array|object|WP_User $userdata {
  *     An array, object, or WP_User object of user data arguments.
  *
- *     @type int         $ID                   User ID. If supplied, the user will be updated.
+ *     @type int         $ID                   User ID. If supplied, the user will be updated. This is deprecated since 4.4.
  *     @type string      $user_pass            The plain-text user password.
  *     @type string      $user_login           The user's login username.
  *     @type string      $user_nicename        The URL-friendly user name.
@@ -1278 +1278 @@
 
         // Are we updating or creating?
         if ( ! empty( $userdata['ID'] ) ) {
+                _deprecated_argument( __FUNCTION__, '4.4', __( 'Supplying a user ID to wp_insert_user to update an existing user is deprecated. Use wp_update_user() instead.' ) ); 
                 $ID = (int) $userdata['ID'];
                 $update = true;
                 $old_user_data = get_userdata( $ID );