Ticket #29942: taxonomy.php.patch

wp-includes/taxonomy.php

@@ -2280 +2280 @@
         $taxonomies = "'" . implode("', '", $taxonomies) . "'";
         $object_ids = implode(', ', $object_ids);
 
-        $select_this = '';
-        if ( 'all' == $fields )
-                $select_this = 't.*, tt.*';
-        else if ( 'ids' == $fields )
-                $select_this = 't.term_id';
-        else if ( 'names' == $fields )
-                $select_this = 't.name';
-        else if ( 'slugs' == $fields )
-                $select_this = 't.slug';
-        else if ( 'all_with_object_id' == $fields )
-                $select_this = 't.*, tt.*, tr.object_id';
+        $query = "SELECT * FROM $wpdb->terms AS t INNER JOIN $wpdb->term_taxonomy AS tt ON tt.term_id = t.term_id INNER JOIN $wpdb->term_relationships AS tr ON tr.term_taxonomy_id = tt.term_taxonomy_id WHERE tt.taxonomy IN ($taxonomies) AND tr.object_id IN ($object_ids) $orderby $order";
+        
+        // Attempt to use cached query
+        $key = md5( $query );
+        $last_changed = wp_cache_get( 'last_changed', 'terms' );
+        if ( ! $last_changed ) {
+                $last_changed = microtime();
+                wp_cache_set( 'last_changed', $last_changed, 'terms' );
+        }
+        $cache_key = "wp_get_object_terms:$key:$last_changed";
+        $cache = wp_cache_get( $cache_key, 'terms' );
+        
+        if ( false !== $cache ) {
+                $_terms = $cache;
+        } else {
+                $_terms = $wpdb->get_results( $query );
+                wp_cache_set( $cache_key, $_terms, 'terms', DAY_IN_SECONDS );
+        }
 
-        $query = "SELECT $select_this FROM $wpdb->terms AS t INNER JOIN $wpdb->term_taxonomy AS tt ON tt.term_id = t.term_id INNER JOIN $wpdb->term_relationships AS tr ON tr.term_taxonomy_id = tt.term_taxonomy_id WHERE tt.taxonomy IN ($taxonomies) AND tr.object_id IN ($object_ids) $orderby $order";
-
         $objects = false;
         if ( 'all' == $fields || 'all_with_object_id' == $fields ) {
-                $_terms = $wpdb->get_results( $query );
                 foreach ( $_terms as $key => $term ) {
                         $_terms[$key] = sanitize_term( $term, $taxonomy, 'raw' );
                 }
+                
                 $terms = array_merge( $terms, $_terms );
                 update_term_cache( $terms );
                 $objects = true;
         } else if ( 'ids' == $fields || 'names' == $fields || 'slugs' == $fields ) {
-                $_terms = $wpdb->get_col( $query );
                 $_field = ( 'ids' == $fields ) ? 'term_id' : 'name';
                 foreach ( $_terms as $key => $term ) {
+                        switch ( $fields ) {
+                                case 'ids' :
+                                        $term = $term->term_id;
+                                break;
+                                
+                                case 'names' :
+                                        $term = $term->name;
+                                break;
+                                
+                                case 'slugs' :
+                                        $term = $term->slug;
+                                break;
+                        }
+                        
                         $_terms[$key] = sanitize_term_field( $_field, $term, $term, $taxonomy, 'raw' );
                 }
                 $terms = array_merge( $terms, $_terms );
         } else if ( 'tt_ids' == $fields ) {
-                $terms = $wpdb->get_col("SELECT tr.term_taxonomy_id FROM $wpdb->term_relationships AS tr INNER JOIN $wpdb->term_taxonomy AS tt ON tr.term_taxonomy_id = tt.term_taxonomy_id WHERE tr.object_id IN ($object_ids) AND tt.taxonomy IN ($taxonomies) $orderby $order");
+                $query = "SELECT tr.term_taxonomy_id FROM $wpdb->term_relationships AS tr INNER JOIN $wpdb->term_taxonomy AS tt ON tr.term_taxonomy_id = tt.term_taxonomy_id WHERE tr.object_id IN ($object_ids) AND tt.taxonomy IN ($taxonomies) $orderby $order";
+                
+                // Attempt to use cached query
+                $key = md5( $query );
+                $cache_key = "wp_get_object_terms:$key:$last_changed";
+                $cache = wp_cache_get( $cache_key, 'terms' );
+                
+                if ( false !== $cache ) {
+                        $terms = $cache;
+                } else {
+                        $terms = $wpdb->get_col($query);
+                        wp_cache_set( $cache_key, $terms, 'terms', DAY_IN_SECONDS );
+                }
+                
                 foreach ( $terms as $key => $tt_id ) {
                         $terms[$key] = sanitize_term_field( 'term_taxonomy_id', $tt_id, 0, $taxonomy, 'raw' ); // 0 should be the term id, however is not needed when using raw context.
                 }
@@ -2334 +2365 @@
         } elseif ( ! $objects ) {
                 $terms = array_values( array_unique( $terms ) );
         }
+        
         /**
          * Filter the terms for a given object or objects.
          *