Ticket #30471: 30471.2.diff

src/wp-includes/functions.php

@@ -2662 +2662 @@
         $json = call_user_func_array( 'json_encode', $args );
 
         // If json_encode() was successful, no need to do more sanity checking.
-        if ( false !== $json ) {
+        // ... unless we're in an old version of PHP, and json_encode() returned
+        // a string containing 'null'. Then we need to do more sanity checking.
+        if ( false !== $json && ( version_compare( PHP_VERSION, '5.5', '>=' ) || false === strpos( $json, 'null' ) ) )  {
                 return $json;
         }
 

tests/phpunit/tests/functions.php

@@ -554 +554 @@
 
                 $this->assertEquals( 'aあb', $utf8 );
 
-                // json_encode() returns different things in different PHP versions.
-                // See: https://core.trac.wordpress.org/ticket/30471
-                if ( version_compare( PHP_VERSION, '5.5', '>=' ) ) {
-                        $expected = '"a\u3042b"';
-                } else {
-                        $expected = 'null';
-                }
+                $this->assertEquals( '"a\u3042b"', wp_json_encode( $eucjp ) );
 
-                $this->assertEquals( $expected, wp_json_encode( $eucjp ) );
-
                 mb_detect_order( $old_charsets );
         }
 
@@ -582 +574 @@
 
                 $this->assertEquals( 'aあb', $utf8 );
 
-                // json_encode() returns different things in different PHP versions.
-                // See: https://core.trac.wordpress.org/ticket/30471
-                if ( version_compare( PHP_VERSION, '5.5', '>=' ) ) {
-                        $expected = '["c","a\u3042b"]';
-                } else {
-                        $expected = '["c",null]';
-                }
+                $this->assertEquals( '["c","a\u3042b"]', wp_json_encode( array( 'c', $eucjp ) ) );
 
-                $this->assertEquals( $expected, wp_json_encode( array( 'c', $eucjp ) ) );
-
                 mb_detect_order( $old_charsets );
         }