Ticket #30681: 30681.diff

src/wp-includes/meta.php

@@ -1419 +1419 @@
                                         $where = $wpdb->prepare( '%s', $meta_value );
                                         break;
 
+                                // Legacy: EXISTS with a value is interpreted as '='.
+                                case 'EXISTS' :
+                                        $meta_compare = '=';
+                                        $where = $wpdb->prepare( '%s', $meta_value );
+                                        break;
+
+                                // 'value' is ignored for NOT EXISTS.
+                                case 'NOT EXISTS' :
+                                        $where = '';
+                                        break;
+
                                 default :
                                         $where = $wpdb->prepare( '%s', $meta_value );
                                         break;

tests/phpunit/tests/post/query.php

@@ -538 +538 @@
         }
 
         /**
+         * @ticket 30681
+         */
+        public function test_meta_query_compare_exists() {
+                $posts = $this->factory->post->create_many( 3 );
+                add_post_meta( $posts[0], 'foo', 'bar' );
+                add_post_meta( $posts[2], 'foo', 'baz' );
+
+                $query = new WP_Query( array(
+                        'fields' => 'ids',
+                        'meta_query' => array(
+                                array(
+                                        'compare' => 'EXISTS',
+                                        'key' => 'foo',
+                                ),
+                        ),
+                ) );
+
+                $this->assertEqualSets( array( $posts[0], $posts[2] ), $query->posts );
+        }
+
+        /**
+         * @ticket 30681
+         */
+        public function test_meta_query_compare_exists_with_value_should_convert_to_equals() {
+                $posts = $this->factory->post->create_many( 3 );
+                add_post_meta( $posts[0], 'foo', 'bar' );
+                add_post_meta( $posts[2], 'foo', 'baz' );
+
+                $query = new WP_Query( array(
+                        'fields' => 'ids',
+                        'meta_query' => array(
+                                array(
+                                        'compare' => 'EXISTS',
+                                        'value' => 'baz',
+                                        'key' => 'foo',
+                                ),
+                        ),
+                ) );
+
+                $this->assertEqualSets( array( $posts[2] ), $query->posts );
+        }
+
+        /**
+         * @ticket 30681
+         */
+        public function test_meta_query_compare_not_exists_should_ignore_value() {
+                $posts = $this->factory->post->create_many( 3 );
+                add_post_meta( $posts[0], 'foo', 'bar' );
+                add_post_meta( $posts[2], 'foo', 'baz' );
+
+                $query = new WP_Query( array(
+                        'fields' => 'ids',
+                        'meta_query' => array(
+                                array(
+                                        'compare' => 'NOT EXISTS',
+                                        'value' => 'bar',
+                                        'key' => 'foo',
+                                ),
+                        ),
+                ) );
+
+                $this->assertEqualSets( array( $posts[1] ), $query->posts );
+        }
+
+        /**
          * @ticket 18158
          * @group meta
          */