Ticket #30860: patch.diff

src/wp-admin/includes/plugin.php

@@ -884 +884 @@
         }
 
         if ( empty( $plugins ) )
-                return;
+                return array();
 
         $invalid = array();
 

tests/phpunit/tests/admin/includesPlugin.php

@@ -4 +4 @@
  * @group admin
  */
 class Tests_Admin_includesPlugin extends WP_UnitTestCase {
+        
+        private function _create_plugin( $data = "<?php\n/*\nPlugin Name: Test\n*/" ) {
+                $name = rand_str() . '.php';
+                $full_name = WP_PLUGIN_DIR . DIRECTORY_SEPARATOR . wp_unique_filename( WP_PLUGIN_DIR, $name );
+
+                $file = fopen( $full_name, 'w' );
+                fwrite( $file, $data );
+                fclose( $file );
+
+                return array( $name, $full_name );
+        }
+
         function test_get_plugin_data() {
                 $data = get_plugin_data( DIR_TESTDATA . '/plugins/hello.php' );
 
@@ -61 +73 @@
                 activate_plugin( 'hello.php' );
                 $test = is_plugin_active( 'hello.php' );
                 $this->assertTrue( $test );
+
+                deactivate_plugins( 'hello.php' );
         }
 
         function test_is_plugin_active_false() {
@@ -79 +93 @@
                 activate_plugin( 'hello.php' );
                 $test = is_plugin_inactive( 'hello.php' );
                 $this->assertFalse( $test );
+
+                deactivate_plugins( 'hello.php' );
         }
+
+        /**
+         * @covers ::get_plugin_files
+         */
+        function test_get_plugin_files_single() {
+                $name = 'hello.php';
+                $this->assertEquals( array( $name ), get_plugin_files( $name ) );
+        }
+
+        /**
+         * @covers ::get_mu_plugins
+         */
+        function test_get_mu_plugins_empty() {
+                $this->assertEquals( array(), get_mu_plugins() );
+        }
+
+        /**
+         * @covers ::_sort_uname_callback
+         */
+        function test_sort_uname_callback() {
+                $this->assertLessThan( 0, _sort_uname_callback( array( 'Name' => 'a' ), array( 'Name' => 'b' ) ) );
+                $this->assertGreaterThan( 0, _sort_uname_callback( array( 'Name' => 'c' ), array( 'Name' => 'b' ) ) );
+                $this->assertEquals( 0, _sort_uname_callback( array( 'Name' => 'a' ), array( 'Name' => 'a' ) ) );
+        }
+
+        /**
+         * @covers ::get_dropins
+         */
+        function test_get_dropins_empty() {
+                $this->assertEquals( array(), get_dropins() );
+        }
+
+        /**
+         * @covers ::_get_dropins
+         */
+        function test_get_dropins_not_empty() {
+                $this->assertGreaterThan( 0, get_dropins() );
+        }
+
+        /**
+         * @covers ::is_network_only_plugin
+         */
+        function test_is_network_only_plugin_hello() {
+                $this->assertFalse( is_network_only_plugin( 'hello.php' ) );
+        }
+
+        /**
+         * @covers ::activate_plugins
+         */
+        function test_activate_plugins_single_no_array() {
+            $name = 'hello.php';
+                activate_plugins( $name );
+                $this->assertTrue( is_plugin_active( $name ) );
+                deactivate_plugins( $name );
+        }
+
+        /**
+         * @covers ::activate_plugins
+         */
+        function test_activate_plugins_single_array() {
+            $name = 'hello.php';
+                activate_plugins( array( $name ) );
+                $this->assertTrue( is_plugin_active( $name ) );
+                deactivate_plugins( $name );
+        }
+
+        /**
+         * @covers ::validate_active_plugins
+         */
+        function test_validate_active_plugins_empty() {
+                $this->assertEquals( array(), validate_active_plugins() );
+        }
+
+        /**
+         * @covers ::validate_active_plugins
+         */
+        function test_validate_active_plugins_remove_invalid() {
+                $plugin = $this->_create_plugin();
+
+                activate_plugin( $plugin[ 0 ] );
+                unlink( $plugin[ 1 ] );
+
+                $result = validate_active_plugins();
+                $this->assertTrue( isset( $result[ $plugin[ 0 ] ] ) );
+        }
+
+        /**
+         * @covers ::is_uninstallable_plugin
+         */
+        function test_is_uninstallable_plugin() {
+                $this->assertFalse( is_uninstallable_plugin( 'hello' ) );
+        }
+
+        /**
+         * @covers ::is_uninstallable_plugin
+         */
+        function test_is_uninstallable_plugin_true() {
+                $plugin = $this->_create_plugin();
+
+                $uninstallable_plugins = (array) get_option( 'uninstall_plugins' );
+                $uninstallable_plugins[ $plugin[ 0 ] ] = TRUE;
+                update_option( 'uninstall_plugins', $uninstallable_plugins );
+
+                $this->assertTrue( is_uninstallable_plugin( $plugin[ 0 ] ) );
+
+                unset( $uninstallable_plugins[ $plugin[ 0 ] ] );
+                update_option( 'uninstall_plugins', $uninstallable_plugins );           
+
+                unlink( $plugin[ 1 ] );
+        }
+        
 }