Ticket #31220: 31220.patch

src/wp-includes/user.php

@@ -631 +631 @@
                                 $orderby = 'ID';
                         } elseif ( 'meta_value' == $qv['orderby'] ) {
                                 $orderby = "$wpdb->usermeta.meta_value";
+                        } elseif ( 'meta_value_num' == $qv['orderby'] ) {
+                                $orderby = "$wpdb->usermeta.meta_value+0";
                         } elseif ( 'include' === $qv['orderby'] && ! empty( $include ) ) {
                                 // Sanitized earlier.
                                 $include_sql = implode( ',', $include );

tests/phpunit/tests/user/query.php

@@ -186 +186 @@
         }
 
         /**
+         * @ticket 31220
+         */
+        public function test_orderby_meta_value_num() {
+                $users = $this->factory->user->create_many( 3, array(
+                        'role' => 'author'
+                ) );
+
+                update_user_meta( $users[0], 'user_age', '101' );
+                update_user_meta( $users[1], 'user_age', '20' );
+                update_user_meta( $users[2], 'user_age', '25' );
+
+                $q = new WP_User_Query( array(
+                        'include' => $users,
+                        'meta_key' => 'user_age',
+                        'orderby' => 'meta_value_num',
+                        'fields' => 'ids'
+                ) );
+
+                $expected = array( $users[1], $users[2], $users[0] );
+
+                $this->assertEquals( $expected, $q->get_results() );
+        }
+
+        /**
          * @ticket 21119
          */
         function test_prepare_query() {