Ticket #31316: 31316.2.diff

src/wp-includes/functions.php

@@ -3181 +3181 @@
                  * This is simple. Could at some point wrap array_column()
                  * if we knew we had an array of arrays.
                  */
-                foreach ( $list as $key => $value ) {
+                $return_array = array();
+                foreach ( $list as $value ) {
                         if ( is_object( $value ) ) {
-                                $list[ $key ] = $value->$field;
+                                $return_array[] = $value->$field;
                         } else {
-                                $list[ $key ] = $value[ $field ];
+                                $return_array[] = $value[ $field ];
                         }
                 }
-                return $list;
+                return $return_array;
         }
 
         /*

tests/phpunit/tests/functions/listFilter.php

@@ -110 +110 @@
                 $this->assertEquals( array( 'f' => 'foo', 'b' => 'bar', 'z' => 'baz' ), $list );
         }
 
+        /**
+         * @ticket 31316
+         */
+        function test_wp_list_pluck_non_indexed_keys() {
+
+                /**
+                 * A non-sequential array of objects, sometimes returned from get_the_terms.
+                 */
+                $test_indexed_array = array(
+                                3 => array(
+                                        'term_id' => 3,
+                                        'name'    => 'Test',
+                                        'slug'    => 'test',
+                                ),
+                                5 => array(
+                                        'term_id' => 5,
+                                        'name'    => 'Foo',
+                                        'slug'    => 'foo',
+                                ),
+                                13 => array(
+                                        'term_id' => 13,
+                                        'name'    => 'Bar',
+                                        'slug'    => 'bar',
+                                ),
+                        );
+
+                /**
+                 * Test a indexed array for good measure.
+                 */
+                $test_non_indexed_array = array(
+                                array(
+                                        'term_id' => 3,
+                                        'name'    => 'Test',
+                                        'slug'    => 'test',
+                                ),
+                                array(
+                                        'term_id' => 5,
+                                        'name'    => 'Foo',
+                                        'slug'    => 'foo',
+                                ),
+                                array(
+                                        'term_id' => 13,
+                                        'name'    => 'Bar',
+                                        'slug'    => 'bar',
+                                ),
+                        );
+
+                /**
+                 * wp_list_pluck should return the array of found values.
+                 */
+                $expected = array( 'test', 'foo', 'bar' );
+
+                /**
+                 * This works fine with the non indexed array.
+                 */
+                $plucked = wp_list_pluck( $test_non_indexed_array, 'slug' );
+                $this->assertEquals( $expected, $plucked );
+
+                /**
+                 * This fails with the indexed array.
+                 */
+                $plucked = wp_list_pluck( $test_indexed_array, 'slug' );
+                $this->assertEquals( $expected, $plucked );
+        }
+
         function test_filter_object_list_nested_array_and() {
                 $list = wp_filter_object_list( $this->object_list, array( 'field4' => array( 'blue' ) ), 'AND' );
                 $this->assertEquals( 1, count( $list ) );