Ticket #31412: 31412.12.patch

src/wp-includes/js/mce-view.js

@@ -163 +163 @@
                 /**
                  * Get a view instance.
                  *
+                 * @param {(String|HTMLElement)} object The textual representation of the view or the view node.
+                 */
+                getInstance: function( object ) {
+                        if ( typeof object === 'string' ) {
+                                return instances[ encodeURIComponent( object ) ];
+                        }
+
+                        return instances[ $( object ).data( 'wpview-text' ) ];
+                },
+
+                /**
+                 * Given a view node, get the view's text.
+                 *
                  * @param {String} text The textual representation of the view.
                  */
-                getInstance: function( text ) {
-                        return instances[ encodeURIComponent( text ) ];
+                getText: function( node ) {
+                        return decodeURIComponent( $( node ).data( 'wpview-text' ) || '' );
                 },
 
                 /**
@@ -188 +201 @@
                  * @param {HTMLElement}    node   The view node to update.
                  */
                 update: function( text, editor, node ) {
-                        var oldText = decodeURIComponent( $( node ).data( 'wpview-text' ) ),
-                                instance = this.getInstance( oldText );
+                        var instance = this.getInstance( node );
 
                         if ( instance ) {
                                 instance.update( text, editor, node );
@@ -203 +215 @@
                  * @param {HTMLElement}    node   The view node to edit.
                  */
                 edit: function( editor, node ) {
-                        var text = decodeURIComponent( $( node ).data( 'wpview-text' ) ),
-                                instance = this.getInstance( text );
+                        var instance = this.getInstance( node );
 
                         if ( instance && instance.edit ) {
-                                instance.edit( text, function( text ) {
+                                instance.edit( instance.text, function( text ) {
                                         instance.update( text, editor, node );
                                 } );
                         }
+                },
+
+                /**
+                 * Remove a given view node from the DOM.
+                 *
+                 * @param {tinymce.Editor} editor The TinyMCE editor instance the view node is in.
+                 * @param {HTMLElement}    node   The view node to remove.
+                 */
+                remove: function( editor, node ) {
+                        var instance = this.getInstance( node );
+
+                        if ( instance ) {
+                                instance.remove( editor, node );
+                        }
                 }
         };
 
@@ -218 +243 @@
          * A Backbone-like View constructor intended for use when rendering a TinyMCE View.
          * The main difference is that the TinyMCE View is not tied to a particular DOM node.
          *
-         * @param {Object} Options.
+         * @param {Object} options Options.
          */
         wp.mce.View = function( options ) {
                 _.extend( this, options );
@@ -631 +656 @@
                         $( node ).data( 'rendered', false );
                         editor.dom.setAttrib( node, 'data-wpview-text', encodeURIComponent( text ) );
                         wp.mce.views.createInstance( this.type, text, this.match( text ).options ).render();
+                },
+
+                /**
+                 * Remove a given view node from the DOM.
+                 *
+                 * @param {tinymce.Editor} editor The TinyMCE editor instance the view node is in.
+                 * @param {HTMLElement}    node   The view node to remove.
+                 */
+                remove: function( editor, node ) {
+                        this.unbindNodes( editor, node, $( node ).find( '.wpview-content' ).get( 0 ) );
+                        editor.dom.remove( node );
                 }
         } );
 } )( window, window.wp, window.jQuery );

src/wp-includes/js/tinymce/plugins/wpview/plugin.js

@@ -72 +72 @@
         }
 
         function removeView( view ) {
-                // TODO: trigger an event to run a clean up function.
-                // Maybe `jQuery( view ).trigger( 'remove' );`?
                 editor.undoManager.transact( function() {
                         handleEnter( view );
-                        editor.dom.remove( view );
+                        wp.mce.views.remove( editor, view );
                 });
         }
 
@@ -107 +105 @@
                 clipboard = dom.create( 'div', {
                         'class': 'wpview-clipboard',
                         'contenteditable': 'true'
-                }, decodeURIComponent( editor.dom.getAttrib( viewNode, 'data-wpview-text' ) ) );
+                }, wp.mce.views.getText( viewNode ) );
 
                 editor.dom.select( '.wpview-body', viewNode )[0].appendChild( clipboard );