Ticket #31476: 31476.patch

src/wp-admin/css/common.css

@@ -2785 +2785 @@
 
 /* @todo: can we use a common class for these? */
 .nav-menus-php .item-edit:before,
-.widget-top a.widget-action:after,
+.widget-top .widget-action:after,
 .control-section .accordion-section-title:after,
 .accordion-section-title:after {
         right: 0;
@@ -2820 +2820 @@
         color: #777;
 }
 
-.widget-top a.widget-action:after {
+.widget-top .widget-action:after {
         padding: 12px 12px 11px;
 }
 
-.widget-top a.widget-action:focus:after {
+.widget-top .widget-action:focus:after {
         -webkit-box-shadow: 0 0 0 1px #5b9dd9,0 0 2px 1px rgba(30,140,190,.8);
         box-shadow: 0 0 0 1px #5b9dd9,0 0 2px 1px rgba(30,140,190,.8);
 }
@@ -2843 +2843 @@
 .control-section.open .accordion-section-title:after,
 #customize-info.open .accordion-section-title:after,
 .nav-menus-php .menu-item-edit-active .item-edit:before,
-.widget.open .widget-top a.widget-action:after {
+.widget.open .widget-top .widget-action:after {
         content: '\f142';
 }
 
@@ -3019 +3019 @@
         /* @todo: evaluate - most of these were likely replaced by dashicons */
         .curtime #timestamp,
         #screen-meta-links a.show-settings,
-        .widget-top a.widget-action,
-        .widget-top a.widget-action:hover,
+        .widget-top .widget-action,
+        .widget-top .widget-action:hover,
         .sidebar-name-arrow,
         .sidebar-name:hover .sidebar-name-arrow,
         .meta-box-sortables .postbox:hover .handlediv,

src/wp-admin/css/customize-widgets.css

@@ -75 +75 @@
         cursor: move;
 }
 
-.customize-control-widget_form.expanded a.widget-action:after {
+.customize-control-widget_form.expanded .widget-action:after {
         content: "\f142";
 }
 
-.customize-control-widget_form.wide-widget-control a.widget-action:after {
+.customize-control-widget_form.wide-widget-control .widget-action:after {
         content: "\f139";
 }
 
-.customize-control-widget_form.wide-widget-control.expanded a.widget-action:after {
+.customize-control-widget_form.wide-widget-control.expanded .widget-action:after {
         content: "\f141";
 }
 
@@ -591 +591 @@
         .widget-title h4 {
                 padding: 13px 15px;
         }
-        .widget-top a.widget-action:after {
+        .widget-top .widget-action:after {
                 padding-top: 9px;
         }
         .widget-reorder-nav span {

src/wp-admin/css/widgets.css

@@ -14 +14 @@
         background: #f7f7f7;
 }
 
-.widget-top a.widget-action,
-.widget-top a.widget-action:hover {
+.widget-top .widget-action,
+.widget-top .widget-action:hover {
         -webkit-box-shadow: none;
         box-shadow: none;
         outline: none;
@@ -48 +48 @@
 }
 
 .deleting .widget-title,
-.deleting .widget-top a.widget-action:after {
+.deleting .widget-top .widget-action:after {
         color: #aaa;
 }
 

src/wp-admin/includes/widgets.php

@@ -194 +194 @@
         echo $sidebar_args['before_widget']; ?>
         <div class="widget-top">
         <div class="widget-title-action">
-                <a class="widget-action hide-if-no-js" href="#available-widgets"></a>
+                <button type="button" class="button-reset widget-action hide-if-no-js"><span class="screen-reader-text"><?php printf( __( '%s widget settings' ), $widget_title ); ?></span></button>
                 <a class="widget-control-edit hide-if-js" href="<?php echo esc_url( add_query_arg( $query_arg ) ); ?>">
                         <span class="edit"><?php _ex( 'Edit', 'widget' ); ?></span>
                         <span class="add"><?php _ex( 'Add', 'widget' ); ?></span>
@@ -223 +223 @@
 
         <div class="widget-control-actions">
                 <div class="alignleft">
-                <a class="widget-control-remove" href="#remove"><?php _e('Delete'); ?></a> |
-                <a class="widget-control-close" href="#close"><?php _e('Close'); ?></a>
+                <button type="button"class="button-link widget-control-remove"><?php _e( 'Delete' ); ?></button> |
+                <button type="button" class="button-link widget-control-close"><?php _e( 'Close' ); ?></button>
                 </div>
                 <div class="alignright<?php if ( 'noform' === $has_form ) echo ' widget-control-noform'; ?>">
                         <?php submit_button( __( 'Save' ), 'button-primary widget-control-save right', 'savewidget', false, array( 'id' => 'widget-' . esc_attr( $id_format ) . '-savewidget' ) ); ?>

src/wp-admin/js/widgets.js

@@ -79 +79 @@
                         wpWidgets.appendTitle( this );
 
                         if ( $this.find( 'p.widget-error' ).length ) {
-                                $this.find( 'a.widget-action' ).trigger('click');
+                                $this.find( '.widget-action' ).trigger('click');
                         }
                 });
 
@@ -195 +195 @@
                                 }
 
                                 if ( addNew ) {
-                                        $widget.find( 'a.widget-action' ).trigger('click');
+                                        $widget.find( '.widget-action' ).trigger('click');
                                 } else {
                                         wpWidgets.saveOrder( $sidebar.attr('id') );
                                 }