Ticket #31621: 31621.diff

src/wp-admin/includes/class-wp-plugins-list-table.php

@@ -515 +515 @@
                 if ( ! empty( $totals['upgrade'] ) && ! empty( $plugin_data['update'] ) )
                         $class .= ' update';
 
-                echo "<tr id='$id' class='$class'>";
+                printf( "<tr id='%s' class='%s' data-slug='%s'>",
+                        $id,
+                        $class,
+                        $plugin_data['slug']
+                );
 
                 list( $columns, $hidden ) = $this->get_column_info();
 

src/wp-admin/js/updates.js

@@ -100 +100 @@
         wp.updates.updatePlugin = function( plugin, slug ) {
                 var $message;
                 if ( 'plugins' === pagenow || 'plugins-network' === pagenow ) {
-                        $message = $( '#' + slug ).next().find( '.update-message' );
+                        $message = $( '[data-slug="' + slug + '"]' ).next().find( '.update-message' );
                 } else if ( 'plugin-install' === pagenow ) {
                         $message = $( '.plugin-card-' + slug ).find( '.update-now' );
                 }
@@ -142 +142 @@
          * @param {object} response
          */
         wp.updates.updateSuccess = function( response ) {
-                var $message;
+                var $updateMessage;
                 if ( 'plugins' === pagenow || 'plugins-network' === pagenow ) {
-                        $message = $( '#' + response.slug ).next().find( '.update-message' );
-                        $( '#' + response.slug ).addClass( 'updated' ).removeClass( 'update' );
+                        var $pluginRow = $( '[data-slug="' + response.slug + '"]' );
+                        $updateMessage = $pluginRow.next().find( '.update-message' );
+                        $pluginRow.addClass( 'updated' ).removeClass( 'update' );
                         $( '#' + response.slug + '-update' ).addClass( 'updated' ).removeClass( 'update' );
                 } else if ( 'plugin-install' === pagenow ) {
-                        $message = $( '.plugin-card-' + response.slug ).find( '.update-now' );
-                        $message.addClass( 'button-disabled' );
+                        $updateMessage = $( '.plugin-card-' + response.slug ).find( '.update-now' );
+                        $updateMessage.addClass( 'button-disabled' );
                 }
 
-                $message.removeClass( 'updating-message' ).addClass( 'updated-message' );
-                $message.text( wp.updates.l10n.updated );
+                $updateMessage.removeClass( 'updating-message' ).addClass( 'updated-message' );
+                $updateMessage.text( wp.updates.l10n.updated );
                 wp.a11y.speak( wp.updates.l10n.updatedMsg );
 
                 wp.updates.decrementCount( 'plugin' );
@@ -169 +170 @@
         wp.updates.updateError = function( response ) {
                 var $message;
                 if ( 'plugins' === pagenow || 'plugins-network' === pagenow ) {
-                        $message = $( '#' + response.slug ).next().find( '.update-message' );
+                        $message = $( '[data-slug="' + response.slug + '"]' ).next().find( '.update-message' );
                 } else if ( 'plugin-install' === pagenow ) {
                         $message = $( '.plugin-card-' + response.slug ).find( '.update-now' );
                 }