Ticket #31634: 31634.patch

src/wp-admin/includes/class-wp-list-table.php

@@ -470 +470 @@
 
                 echo "</select>\n";
 
-                submit_button( __( 'Apply' ), 'action', '', false, array( 'id' => "doaction$two" ) );
+                submit_button( __( 'Apply' ), 'action', '', false, array( 'id' => "doaction$two", 'disabled' => 'disabled' ) );
                 echo "\n";
         }
 

src/wp-admin/js/common.js

@@ -204 +204 @@
                         adminbar: $adminbar.height(),
                         menu: $adminMenuWrap.height()
                 },
-                $headerEnd = $( '.wp-header-end' );
+                $headerEnd = $( '.wp-header-end' ),
+                listTable = $( '.wp-list-table' ).closest( 'form' ),
+                doActions = listTable.find( '#doaction, #doaction2' );
+                actions = listTable.find( '#bulk-action-selector-top, #bulk-action-selector-bottom' );
 
 
         // when the menu is folded, make the fly-out submenu header clickable
@@ -416 +419 @@
 
         // Init screen meta
         screenMeta.init();
+        
+        /**
+         * Enable and Disable Apply button in wp-list
+         *
+         * @param {jQuery.Event} e
+         */
+        function setApplyButton( e ) {
+                
+                if ( ( 'SELECT' === e.target.tagName && e.target.value == -1 ) ) {
+                        doActions.prop( 'disabled', true );
+            return
+        }
+                
+                var checkedLength = listTable.find( 'table tbody .check-column input[type="checkbox"]:checked' ).length;
+                
+                if( checkedLength && $( '#bulk-action-selector-top' ).val() != -1) {
+                        doActions.prop( 'disabled', false );
+                } else {
+                        doActions.prop( 'disabled', true );
+                }
+                
+        }
+        
+        // This event needs to be delegated. Ticket #31634
+        $body.on( 'click', '.cancel', function( event ) { 
+                setApplyButton( event );
+        });
+        
+        // This event needs to be delegated. Ticket #31634
+        $body.on( 'change', '#bulk-action-selector-top, #bulk-action-selector-bottom', function( event ) { 
+                actions.not( this ).val( this.value );
+                setApplyButton( event );
+        });
 
         // This event needs to be delegated. Ticket #37973.
         $body.on( 'click', 'tbody > tr > .check-column :checkbox', function( event ) {
@@ -444 +480 @@
                 $(this).closest('table').children('thead, tfoot').find(':checkbox').prop('checked', function() {
                         return ( 0 === unchecked.length );
                 });
+                
+                setApplyButton( event );
 
                 return true;
         });
@@ -482 +520 @@
 
                                 return false;
                         });
+                
+                setApplyButton( event );
+                
         });
 
         // Show row actions on keyboard focus of its parent container element or any other elements contained within

src/wp-admin/js/inline-edit-post.js

@@ -62 +62 @@
 
                 $('select[name="_status"] option[value="future"]', bulkRow).remove();
 
-                $('#doaction, #doaction2').click(function(e){
+                $( '#doaction, #doaction2' ).click(function(e){
                         var n;
 
                         t.whichBulkButtonId = $( this ).attr( 'id' );
                         n = t.whichBulkButtonId.substr( 2 );
 
                         if ( 'edit' === $( 'select[name="' + n + '"]' ).val() ) {
+                                $( '#doaction, #doaction2' ).prop( 'disabled', true );
                                 e.preventDefault();
                                 t.setBulk();
-                        } else if ( $('form#posts-filter tr.inline-editor').length > 0 ) {
+                        } else if ( $( 'form#posts-filter tr.inline-editor' ).length > 0 ) {
                                 t.revert();
                         }
                 });
@@ -316 +317 @@
                         }
                 }
 
-                return false;
         },
 
         getId : function(o) {