Ticket #31779: 31779.2.diff

src/wp-admin/css/common.css

@@ -3147 +3147 @@
         line-height: 180%;
 }
 
+#file-editor-warning .file-editor-warning-content {
+        margin: 25px;
+}
+
 /* @todo: can we use a common class for these? */
 .nav-menus-php .item-edit:before,
 .widget-top .widget-action .toggle-indicator:before,

src/wp-admin/plugin-editor.php

@@ -280 +280 @@
 <br class="clear" />
 </div>
 <?php
+$hide_notice = get_user_meta( get_current_user_id(), 'hide_plugin_editor_notice', true ); 
+if ( empty( $hide_notice ) ) :
+?>
+<div id="file-editor-warning" class="notification-dialog-wrap file-editor-warning">
+        <div class="notification-dialog-background"></div>
+        <div class="notification-dialog" role="dialog" aria-labelledby="file-editor-warning-title" tabindex="0">
+                <div class="file-editor-warning-content">
+                        <h1 id="file-editor-warning-title"><?php _e( 'Caution!' ); ?></h1>
+                        <p><?php _e( 'You appear to be making direct edits to your plugin in the WordPress dashboard. It is <strong>strongly</strong> recommended that you don&#8217;t! Editing plugins directly may introduce incompatibilities that break your site or even leave you staring at the dreaded &#8220;White Screen of Death&#8221;. Your changes may also be overwritten by future updates.' ); ?></p>
+                        <p><?php _e( 'If you absolutely must edit a plugin this way, WordPress will attempt to prevent you from being locked out from the dashboard entirely, but cannot guarantee results. Once dismissed, this notice will not appear again.' ); ?></p>
+                </div>
+<?php // TODO: Make that notice=0 thing do something ?>
+                <a class="file-editor-warning-close notice-dismiss" href="<?php echo esc_url( self_admin_url( 'plugin-editor.php?notice=0' ) ); ?>" aria-label="<?php esc_attr_e( 'Dismiss the file editor warning' ); ?>"><?php _e( 'Dismiss' ); ?></a>
+        </div>
+</div>
+<?php
+endif; // editor warning notice
 
 include(ABSPATH . "wp-admin/admin-footer.php");