Ticket #32152: 32152.2.diff

wp-admin/css/list-tables.css

@@ -4 +4 @@
 }
 
 .post-com-count {
+        float: left;
         background: none;
         height: 1.3em;
         line-height: 1.1em;
-        display: block;
         text-decoration: none;
         padding: 0 0 6px;
-        cursor: pointer;
-        background-position: center -80px;
-        background-repeat: no-repeat;
         color: #fff;
+        text-align: center;
+        position: relative;
+        margin-top: 5px;
 }
 
-.post-com-count:after {         /* draw bubble connector using CSS! */
+.post-com-count:after {
         content: "";
         display: block;
         width: 0;
         height: 0;
         margin-left: 8px;
-        border-top: 5px solid #b4b9be;
+        border-top: 5px solid #767676;
         border-right: 5px solid transparent;
 }
 
-.post-com-count span {
+.post-com-count .comment-count {
         font-size: 11px;
         font-weight: 600;
-        height: 1.4em;
-        line-height: 1.4em;
-        min-width: 0.7em;
-        padding: 0 6px;
-        display: inline-block;
+        /* the following are calculated on the font size
+           and need 8 decimals to avoid different roundings in different browsers */
+        height: 1.95454545em;
+        line-height: 1.96363636;
+        min-width: 0.72727272em;
+        padding: 0 8px;
+        display: block;
         -webkit-border-radius: 5px;
         border-radius: 5px;
-        background-color: #b4b9be;
+        background-color: #767676;
         color: #fff;
+        overflow: hidden;
 }
 
-.post-com-count:hover {
-        background-position: center -3px;
+.post-com-count .comment-count-pending {
+        display: none;
 }
 
-.post-com-count:hover span {
-        background-color: #00a0d2;
+.has-pending .post-com-count .comment-count-pending {
+        display: block;
+        background: #d54e21;
+        font-size: 9px;
+        font-weight: 600;
+        /* the following are calculated on the font size
+           and need 8 decimals to avoid different roundings in different browsers */
+        height: 1.75454545em;
+        line-height: 1.76363636;
+        min-width: 0.2727272em;
+        padding: 0 5px;
+        -webkit-border-radius: 10px;
+        border-radius: 10px;
+        color: #fff;
+        overflow: hidden;
+        position: absolute;
+        top: -4px;
+        left: 85%;
+        border: 2px solid #fff;
 }
 
-.post-com-count:hover:after {
-        border-top: 5px solid #00a0d2;
-}
 
-strong .post-com-count {
-        background-position: center -55px;
-}
-
-strong .post-com-count span {
-        background-color: #0073aa;
-}
-
-strong .post-com-count:after {
-        border-top: 5px solid #0073aa;
-}
-
 .column-response .post-com-count {
         float: left;
         margin-right: 5px;

wp-admin/includes/class-wp-list-table.php

@@ -612 +612 @@
          * @param int $pending_comments Number of pending comments.
          */
         protected function comments_bubble( $post_id, $pending_comments ) {
-                $pending_phrase = sprintf( __( '%s pending' ), number_format( $pending_comments ) );
+                $approved_comments_number = number_format_i18n( get_comments_number() );
+                $pending_comments_number = number_format( $pending_comments );
+                $count_phrase = sprintf( __( '%s approved and %s pending comments' ), $approved_comments_number, $pending_comments_number );
 
-                if ( $pending_comments )
-                        echo '<strong>';
+                if ( $pending_comments ) {
+                        echo '<strong class="has-pending">';
+                }
 
-                echo "<a href='" . esc_url( add_query_arg( 'p', $post_id, admin_url( 'edit-comments.php' ) ) ) . "' title='" . esc_attr( $pending_phrase ) . "' class='post-com-count'><span class='comment-count'>" . number_format_i18n( get_comments_number() ) . "</span></a>";
+                // don't output a link if no comments
+                if ( ! $approved_comments_number && ! $pending_comments_number ) {
+                        printf( '<span class="post-com-count"><span class="comment-count comment-count-no-comments" aria-hidden="true">%s</span><span class="screen-reader-text">%s</span></span>',
+                                $approved_comments_number,
+                                $count_phrase
+                        );
 
-                if ( $pending_comments )
+                } elseif (  $pending_comments ) {
+                        printf( '<a href="%s" aria-label="%s" class="post-com-count"><span class="comment-count">%s</span><span class="comment-count-pending">%s</span></a>',
+                                esc_url( add_query_arg( 'p', $post_id, admin_url( 'edit-comments.php' ) ) ),
+                                esc_attr( $count_phrase ),
+                                $approved_comments_number,
+                                $pending_comments_number
+                        );
+                } else {
+                        printf( '<a href="%s" aria-label="%s" class="post-com-count"><span class="comment-count">%s</span></a>',
+                                esc_url( add_query_arg( 'p', $post_id, admin_url( 'edit-comments.php' ) ) ),
+                                esc_attr( $count_phrase ),
+                                $approved_comments_number,
+                                $pending_comments_number
+                        );
+                }
+
+                if ( $pending_comments ) {
                         echo '</strong>';
+                }
         }
 
         /**