Ticket #32248: 32248.diff

src/wp-includes/taxonomy.php

@@ -1842 +1842 @@
         }
 
         if ( ! empty( $args['name'] ) ) {
-                if ( is_array( $args['name'] ) ) {
-                        $name = array_map( 'sanitize_text_field', $args['name'] );
-                        $where .= " AND t.name IN ('" . implode( "', '", array_map( 'esc_sql', $name ) ) . "')";
-                } else {
-                        $name = sanitize_text_field( $args['name'] );
-                        $where .= $wpdb->prepare( " AND t.name = %s", $name );
+                $names = (array) $args['name'];
+                foreach ( $names as &$_name ) {
+                        $_name = sanitize_term_field( 'name', $_name, 0, reset( $taxonomies ), 'db' );
                 }
+
+                $where .= " AND t.name IN ('" . implode( "', '", array_map( 'esc_sql', $names ) ) . "')";
         }
 
         if ( ! empty( $args['slug'] ) ) {

tests/phpunit/tests/term/getTerms.php

@@ -541 +541 @@
         }
 
         /**
+         * @ticket 32248
+         */
+        public function test_name_should_match_encoded_html_entities() {
+                register_taxonomy( 'wptests_tax', 'post' );
+
+                $t = $this->factory->term->create( array(
+                        'taxonomy' => 'wptests_tax',
+                        'name' => 'Foo & Bar',
+                        'slug' => 'foo-and-bar',
+                ) );
+
+                $found = get_terms( 'wptests_tax', array(
+                        'hide_empty' => false,
+                        'fields' => 'ids',
+                        'name' => 'Foo & Bar',
+                ) );
+                $this->assertEqualSets( array( $t ), $found );
+
+                // array format.
+                $found = get_terms( 'wptests_tax', array(
+                        'hide_empty' => false,
+                        'fields' => 'ids',
+                        'name' => array( 'Foo & Bar' ),
+                ) );
+                $this->assertEqualSets( array( $t ), $found );
+        }
+
+        /**
          * @ticket 29839
          */
         public function test_childless_should_return_all_terms_for_flat_hierarchy() {