Ticket #32509: 32509.patch

src/wp-admin/includes/class-wp-media-list-table.php

@@ -316 +316 @@
                 $attributes = 'class="column-icon media-icon ' . $mime . '-icon"' . $style;
 ?>
                 <td <?php echo $attributes ?>><?php
-                        if ( $thumb = wp_get_attachment_image( $post->ID, array( 80, 60 ), true ) ) {
+                        if ( $this->is_trash || ! $user_can_edit ) {
+                                // Preserve the original alt attribute for non-linked images.
+                                $thumb_attr = '';
+                        } else {
+                                // For linked images the alt attribute should communicate the destination of the link or action taken.
+                                $thumb_attr = array( 'alt' => esc_attr( sprintf( __( 'Edit &#8220;%s&#8221;' ), $att_title ) ) );
+                        }
+                        if ( $thumb = wp_get_attachment_image( $post->ID, array( 80, 60 ), true, $thumb_attr ) ) {
                                 if ( $this->is_trash || ! $user_can_edit ) {
                                         echo $thumb;
                                 } else {
 ?>
-                                <a href="<?php echo get_edit_post_link( $post->ID ); ?>" title="<?php echo esc_attr( sprintf( __( 'Edit &#8220;%s&#8221;' ), $att_title ) ); ?>">
+                                <a href="<?php echo get_edit_post_link( $post->ID ); ?>">
                                         <?php echo $thumb; ?>
                                 </a>
 
@@ -338 +345 @@
                         <?php if ( $this->is_trash || ! $user_can_edit ) {
                                 echo $att_title;
                         } else { ?>
-                        <a href="<?php echo get_edit_post_link( $post->ID ); ?>"
-                                title="<?php echo esc_attr( sprintf( __( 'Edit &#8220;%s&#8221;' ), $att_title ) ); ?>">
-                                <?php echo $att_title; ?></a>
+                        <a href="<?php echo get_edit_post_link( $post->ID ); ?>">
+                                <span aria-hidden="true"><?php echo $att_title; ?></span>
+                                <span class="screen-reader-text"><?php echo esc_attr( sprintf( __( 'Edit &#8220;%s&#8221;' ), $att_title ) ); ?></span>
+                        </a>
                         <?php };
                         _media_states( $post ); ?></strong>
-                        <p class="filename"><?php echo wp_basename( $post->guid ); ?></p>
+                        <p class="filename"><span class="screen-reader-text"><?php _e( 'File name:' ); ?> </span><?php echo wp_basename( $post->guid ); ?></p>
 <?php
                 echo $this->row_actions( $this->_get_row_actions( $post, $att_title ) );
 ?>