WordPress.org
Get WordPress

Make WordPress Core

Ticket #33311: 33311-Fix-excessive-resource-usage-due-to-animating-GIF-1.patch

File 33311-Fix-excessive-resource-usage-due-to-animating-GIF-1.patch, 4.1 KB (added by niklasbr, 10 years ago)

First patch

  • wp-admin/css/common-rtl.css 

    From a48d554c48a6479d2cd9a3203ea9421fe19216c2 Mon Sep 17 00:00:00 2001
From: Niklas <niklas@lynks.se>
Date: Mon, 10 Aug 2015 20:31:48 +0200
Subject: [PATCH] Fix excessive resource usage due to animating GIF after
 ThickBox load finishes

---
 wp-admin/css/common-rtl.css          | 17 +----------------
 wp-admin/css/common.css              | 17 +----------------
 wp-includes/js/thickbox/thickbox.css |  2 +-
 wp-includes/js/thickbox/thickbox.js  |  6 +++---
 4 files changed, 6 insertions(+), 36 deletions(-)

diff --git a/wp-admin/css/common-rtl.css b/wp-admin/css/common-rtl.css
index b009875..25ecd34 100644
    a b body.import-php #TB_window, 
    26102610body.plugins-php #TB_window,
    26112611body.update-core-php #TB_window,
    26122612body.index-php #TB_window {
    2613         background: #fcfcfc url( ../images/spinner.gif ) no-repeat center;
    2614 }
    2615 
    2616 @media print,
    2617         (-webkit-min-device-pixel-ratio: 1.25),
    2618         (min-resolution: 120dpi) {
    2619 
    2620         body.plugin-install-php #TB_window,
    2621         body.import-php #TB_window,
    2622         body.plugins-php #TB_window,
    2623         body.update-core-php #TB_window,
    2624         body.index-php #TB_window {
    2625                 background: #fcfcfc url( ../images/spinner-2x.gif ) no-repeat center;
    2626                 -webkit-background-size: 20px 20px;
    2627                 background-size: 20px 20px;
    2628         }
     2613        background-position: center;
    26292614}
    26302615
    26312616body.plugin-install-php #TB_title,

  • wp-admin/css/common.css 

    diff --git a/wp-admin/css/common.css b/wp-admin/css/common.css
index d3765d9..94f479e 100644
    a b body.import-php #TB_window, 
    26102610body.plugins-php #TB_window,
    26112611body.update-core-php #TB_window,
    26122612body.index-php #TB_window {
    2613         background: #fcfcfc url( ../images/spinner.gif ) no-repeat center;
    2614 }
    2615 
    2616 @media print,
    2617         (-webkit-min-device-pixel-ratio: 1.25),
    2618         (min-resolution: 120dpi) {
    2619 
    2620         body.plugin-install-php #TB_window,
    2621         body.import-php #TB_window,
    2622         body.plugins-php #TB_window,
    2623         body.update-core-php #TB_window,
    2624         body.index-php #TB_window {
    2625                 background: #fcfcfc url( ../images/spinner-2x.gif ) no-repeat center;
    2626                 -webkit-background-size: 20px 20px;
    2627                 background-size: 20px 20px;
    2628         }
     2613        background-position: center;
    26292614}
    26302615
    26312616body.plugin-install-php #TB_title,

  • wp-includes/js/thickbox/thickbox.css 

    diff --git a/wp-includes/js/thickbox/thickbox.css b/wp-includes/js/thickbox/thickbox.css
index 0549c79..e47f5aa 100644
    a b  
    1212
    1313#TB_window {
    1414        position: fixed;
    15         background: #fff;
     15        background-color: #fff;
    1616        z-index: 100050; /* Above DFW. */
    1717        visibility: hidden;
    1818        text-align: left;

  • wp-includes/js/thickbox/thickbox.js 

    diff --git a/wp-includes/js/thickbox/thickbox.js b/wp-includes/js/thickbox/thickbox.js
index 60a9eb7..b5e9d1d 100644
    a b function tb_show(caption, url, imageGroup) {//function called when the user clic 
    3939                        jQuery("body","html").css({height: "100%", width: "100%"});
    4040                        jQuery("html").css("overflow","hidden");
    4141                        if (document.getElementById("TB_HideSelect") === null) {//iframe to hide select elements in ie6
    42                                 jQuery("body").append("<iframe id='TB_HideSelect'>"+thickboxL10n.noiframes+"</iframe><div id='TB_overlay'></div><div id='TB_window'></div>");
     42                                jQuery("body").append("<iframe id='TB_HideSelect'>"+thickboxL10n.noiframes+"</iframe><div id='TB_overlay'></div><div id='TB_window' class='spinner'></div>");
    4343                                jQuery("#TB_overlay").click(tb_remove);
    4444                        }
    4545                }else{//all others
    4646                        if(document.getElementById("TB_overlay") === null){
    47                                 jQuery("body").append("<div id='TB_overlay'></div><div id='TB_window'></div>");
     47                                jQuery("body").append("<div id='TB_overlay'></div><div id='TB_window' class='spinner'></div>");
    4848                                jQuery("#TB_overlay").click(tb_remove);
    4949                                jQuery( 'body' ).addClass( 'modal-open' );
    5050                        }
    … … function tb_show(caption, url, imageGroup) {//function called when the user clic 
    260260//helper functions below
    261261function tb_showIframe(){
    262262        jQuery("#TB_load").remove();
    263         jQuery("#TB_window").css({'visibility':'visible'});
     263        jQuery("#TB_window").css({'visibility':'visible'}).removeClass('spinner');
    264264}
    265265
    266266function tb_remove() {