Ticket #33326: site-icon-check-bool.diff

src/wp-includes/general-template.php

@@ -745 +745 @@
                 } else {
                         $size_data = array( $size, $size );
                 }
-                $url_data = wp_get_attachment_image_src( $site_icon_id, $size_data );
-                $url = $url_data[0];
+                if ( $url_data = wp_get_attachment_image_src( $site_icon_id, $size_data ) ) {
+                        $url = $url_data[0];
+                }
         }
 
         return $url;
@@ -770 +771 @@
  * @return bool
  */
 function has_site_icon( $blog_id = null ) {
-        return !! get_site_icon_url( $blog_id, 512 );
+        return (bool) get_site_icon_url( $blog_id, 512 );
 }
 
 /**