Ticket #33717: 337171.14.patch

src/wp-admin/css/dashboard.css

@@ -821 +821 @@
         position: relative;
 }
 
+#activity-widget #the-comment-list .comment-item .attention {
+        display: none;
+        color: #d54e21;
+        font-size: 90%;
+}
+
 #activity-widget #the-comment-list .avatar {
         position: absolute;
         top: 12px;
@@ -857 +863 @@
         width: 4px;
 }
 
+#activity-widget #the-comment-list .unapproved .attention {
+        display: block;
+}
+
 #activity-widget #the-comment-list .spam-undo-inside .avatar,
 #activity-widget #the-comment-list .trash-undo-inside .avatar {
         position: relative;

src/wp-admin/css/list-tables.css

@@ -217 +217 @@
         background-color: #f5f5f5;
 }
 
+#the-comment-list .comment .attention {
+        display: none;
+        color: #d54e21;
+        font-size: 90%;
+}
+
 #the-comment-list .unapproved th,
 #the-comment-list .unapproved td {
         background-color: #fef7f1;
@@ -230 +236 @@
         margin-left: 4px;
 }
 
+#the-comment-list .comment.unapproved .attention {
+        display: block;
+}
+
 #the-comment-list .approve a {
         color: #006505;
 }

src/wp-admin/includes/class-wp-comments-list-table.php

@@ -882 +882 @@
                         }
                 }
 
+                if ( 0 === (int) $comment->comment_approved && true === (bool) get_comment_meta( $comment->comment_ID, '_wp_comment_author_notification_optin', true ) ) {
+                        /* translators: %s is the comment author name. */
+                        echo '<p class="attention"><span class="dashicons dashicons-info"></span> ' . sprintf( esc_html__( '%s has opted in to receive a notification on comment’s approval.' ), get_comment_author( $comment ) ) . '</p>';
+                }
+
                 comment_text( $comment );
 
                 if ( $this->user_can ) {

src/wp-admin/includes/dashboard.php

@@ -827 +827 @@
                                 }
                                 ?>
                         </p>
-
                                 <?php
+                                if ( 0 === (int) $comment->comment_approved && true === (bool) get_comment_meta( $comment->comment_ID, '_wp_comment_author_notification_optin', true ) ) :
+                                        ?>
+                                                <p class="attention">
+                                                        <span class="dashicons dashicons-info"></span>
+                                                        <?php
+                                                        /* translators: %s is the comment author name. */
+                                                        printf( esc_html__( '%s has opted in to receive a notification on comment’s approval.' ), get_comment_author( $comment ) );
+                                                        ?>
+                                                </p>
+                                        <?php
+                                        endif;
+
                         else :
                                 switch ( $comment->comment_type ) {
                                         case 'pingback':

src/wp-comments-post.php

@@ -22 +22 @@
 
 nocache_headers();
 
-$comment = wp_handle_comment_submission( wp_unslash( $_POST ) );
-if ( is_wp_error( $comment ) ) {
-        $data = (int) $comment->get_error_data();
-        if ( ! empty( $data ) ) {
+if ( isset( $_POST['wp-comment-approved-notification-optin'], $_POST['comment_ID'], $_POST['moderation-hash'] ) ) {
+        $comment = get_comment( $_POST['comment_ID'] );
+
+        if ( ! is_null( $comment->comment_ID ) && hash_equals( $_POST['moderation-hash'], wp_hash( $comment->comment_date_gmt ) ) ) {
+                update_comment_meta( $comment->comment_ID, '_wp_comment_author_notification_optin', true );
+        } else {
                 wp_die(
-                        '<p>' . $comment->get_error_message() . '</p>',
-                        __( 'Comment Submission Failure' ),
+                        '<p>' . __( 'Sorry we haven’t found your comment.' ) . '</p>',
+                        __( 'Comment Notification opt-in failure' ),
                         array(
-                                'response'  => $data,
                                 'back_link' => true,
                         )
                 );
-        } else {
-                exit;
         }
-}
+} else {
+        $comment = wp_handle_comment_submission( wp_unslash( $_POST ) );
+        if ( is_wp_error( $comment ) ) {
+                $data = (int) $comment->get_error_data();
+                if ( ! empty( $data ) ) {
+                        wp_die(
+                                '<p>' . $comment->get_error_message() . '</p>',
+                                __( 'Comment Submission Failure' ),
+                                array(
+                                        'response'  => $data,
+                                        'back_link' => true,
+                                )
+                        );
+                } else {
+                        exit;
+                }
+        }
 
-$user            = wp_get_current_user();
-$cookies_consent = ( isset( $_POST['wp-comment-cookies-consent'] ) );
+        $user            = wp_get_current_user();
+        $cookies_consent = ( isset( $_POST['wp-comment-cookies-consent'] ) );
 
-/**
- * Perform other actions when comment cookies are set.
- *
- * @since 3.4.0
- * @since 4.9.6 The `$cookies_consent` parameter was added.
- *
- * @param WP_Comment $comment         Comment object.
- * @param WP_User    $user            Comment author's user object. The user may not exist.
- * @param bool       $cookies_consent Comment author's consent to store cookies.
- */
-do_action( 'set_comment_cookies', $comment, $user, $cookies_consent );
+        /**
+         * Perform other actions when comment cookies are set.
+         *
+         * @since 3.4.0
+         * @since 4.9.6 The `$cookies_consent` parameter was added.
+         *
+         * @param WP_Comment $comment         Comment object.
+         * @param WP_User    $user            Comment author's user object. The user may not exist.
+         * @param bool       $cookies_consent Comment author's consent to store cookies.
+         */
+        do_action( 'set_comment_cookies', $comment, $user, $cookies_consent );
+}
 
 $location = empty( $_POST['redirect_to'] ) ? get_comment_link( $comment ) : $_POST['redirect_to'] . '#comment-' . $comment->comment_ID;
 

src/wp-includes/class-walker-comment.php

@@ -275 +275 @@
                 return $comment_text;
         }
 
+        /**
+         * Outputs the awaiting moderation text.
+         *
+         * @since 5.7.0
+         *
+         * @param WP_Comment $comment Comment to display.
+         */
+        protected function awaiting_moderation_text( $comment ) {
+                if ( 0 !== (int) $comment->comment_approved ) {
+                        return;
+                }
+
+                $commenter = wp_get_current_commenter();
+                if ( $commenter['comment_author_email'] ) {
+                        $moderation_note = __( 'Your comment is awaiting moderation.' );
+                } else {
+                        $moderation_note = __( 'Your comment is awaiting moderation. This is a preview, your comment will be visible after it has been approved.' );
+                }
+
+                printf( '<em class="comment-awaiting-moderation">%s</em>', esc_html( $moderation_note ) );
+        }
+
+        /**
+         * Outputs the comment's approval notification form.
+         *
+         * @since 5.7.0
+         *
+         * @param WP_Comment $comment Comment to display.
+         */
+        protected function comment_approval_notification_form( $comment ) {
+                if ( 0 !== (int) $comment->comment_approved || ! has_action( 'comment_unapproved_to_approved', 'wp_new_comment_notify_comment_author' ) ) {
+                        return;
+                }
+
+                if ( true === (bool) get_comment_meta( $comment->comment_ID, '_wp_comment_author_notification_optin', true ) ) :
+                        ?>
+                        <p class="wp-comment-approved-notification-optedin"><?php esc_html_e( 'You will receive an email when your comment has been approved.' ); ?></p>
+                <?php else : ?>
+                        <form action="<?php echo esc_url( site_url( '/wp-comments-post.php' ) ); ?>" method="post">
+                                <p>
+                                        <label for="wp-comment-approved-notification-optin">
+                                                <input type="checkbox" id="wp-comment-approved-notification-optin" name="wp-comment-approved-notification-optin">
+                                                <?php esc_html_e( 'I want to be notified by email when my comment is approved.' ); ?>
+                                        </label>
+                                </p>
+                                <input type="hidden" name="comment_ID" value="<?php echo absint( $comment->comment_ID ); ?>">
+                                <input type="hidden" name="moderation-hash" value="<?php echo wp_hash( $comment->comment_date_gmt ); ?>">
+                                <input type="submit" class="button" value="<?php echo esc_html_x( 'Save', 'comment approved notification form' ); ?>">
+                        </form>
+                        <?php
+                endif;
+        }
+
         /**
          * Outputs a single comment.
          *
@@ -297 +350 @@
 
                 $commenter          = wp_get_current_commenter();
                 $show_pending_links = isset( $commenter['comment_author'] ) && $commenter['comment_author'];
-
-                if ( $commenter['comment_author_email'] ) {
-                        $moderation_note = __( 'Your comment is awaiting moderation.' );
-                } else {
-                        $moderation_note = __( 'Your comment is awaiting moderation. This is a preview; your comment will be visible after it has been approved.' );
-                }
                 ?>
                 <<?php echo $tag; ?> <?php comment_class( $this->has_children ? 'parent' : '', $comment ); ?> id="comment-<?php comment_ID(); ?>">
                 <?php if ( 'div' !== $args['style'] ) : ?>
@@ -328 +375 @@
                         );
                         ?>
                 </div>
-                <?php if ( '0' == $comment->comment_approved ) : ?>
-                <em class="comment-awaiting-moderation"><?php echo $moderation_note; ?></em>
+                <?php $this->awaiting_moderation_text( $comment ); ?>
                 <br />
-                <?php endif; ?>
 
                 <div class="comment-meta commentmetadata">
                         <?php
@@ -362 +407 @@
                                 )
                         )
                 );
+
+                // Output the comment approval notification form if needed.
+                $this->comment_approval_notification_form( $comment );
                 ?>
 
                 <?php
@@ -401 +449 @@
 
                 $commenter          = wp_get_current_commenter();
                 $show_pending_links = ! empty( $commenter['comment_author'] );
-
-                if ( $commenter['comment_author_email'] ) {
-                        $moderation_note = __( 'Your comment is awaiting moderation.' );
-                } else {
-                        $moderation_note = __( 'Your comment is awaiting moderation. This is a preview; your comment will be visible after it has been approved.' );
-                }
                 ?>
                 <<?php echo $tag; ?> id="comment-<?php comment_ID(); ?>" <?php comment_class( $this->has_children ? 'parent' : '', $comment ); ?>>
                         <article id="div-comment-<?php comment_ID(); ?>" class="comment-body">
@@ -450 +492 @@
                                                 ?>
                                         </div><!-- .comment-metadata -->
 
-                                        <?php if ( '0' == $comment->comment_approved ) : ?>
-                                        <em class="comment-awaiting-moderation"><?php echo $moderation_note; ?></em>
-                                        <?php endif; ?>
+                                        <?php $this->awaiting_moderation_text( $comment ); ?>
                                 </footer><!-- .comment-meta -->
 
                                 <div class="comment-content">
-                                        <?php comment_text(); ?>
+                                        <?php
+                                        comment_text();
+
+                                        // Output the comment approval notification form if needed.
+                                        $this->comment_approval_notification_form( $comment );
+                                        ?>
                                 </div><!-- .comment-content -->
 
                                 <?php

src/wp-includes/comment.php

@@ -2348 +2348 @@
         return wp_notify_postauthor( $comment_ID );
 }
 
+/**
+ * Notify a comment author when their comment gets approved.
+ *
+ * This notification is only sent once when the comment status
+ * changes from unapproved to approved.
+ *
+ * @since 5.7.0
+ *
+ * @param int|WP_Comment $comment_id Comment ID or WP_Comment object.
+ * @return bool Whether the email was sent successfully.
+ */
+function wp_new_comment_notify_comment_author( $comment_id ) {
+        $comment = get_comment( $comment_id );
+
+        if ( ! $comment ) {
+                return false;
+        }
+
+        $post           = get_post( $comment->comment_post_ID );
+        $comment_author = get_user_by( 'email', $comment->comment_author_email );
+
+        if ( ! $post ) {
+                return false;
+        }
+
+        // The comment was left by the post author.
+        if ( $comment->user_id === $post->post_author || get_userdata( $post->post_author ) === $comment_author ) {
+                return false;
+        }
+
+        // Make sure the comment author can notified by email.
+        if ( empty( $comment->comment_author_email ) ) {
+                return false;
+        }
+
+        if ( true !== (bool) get_comment_meta( $comment->comment_ID, '_wp_comment_author_notification_optin', true ) ) {
+                return false;
+        }
+
+        /**
+         * The blogname option is escaped with esc_html when
+         * saved into the database, we need to reverse this for
+         * the plain text area of the email.
+         */
+        $blogname = wp_specialchars_decode( get_option( 'blogname' ), ENT_QUOTES );
+
+        /* translators: 1: blog name, 2: post title */
+        $subject = sprintf( __( '[%1$s] Your comment on "%2$s" has been approved' ), $blogname, $post->post_title );
+
+        if ( ! empty( $comment->comment_author ) ) {
+                /* translators: 1: comment author's name */
+                $notify_message = sprintf( __( 'Howdy %s,' ), $comment->comment_author ) . "\r\n\r\n";
+        } else {
+                $notify_message = __( 'Howdy,' ) . "\r\n\r\n";
+        }
+
+        /* translators: 1: post title */
+        $notify_message .= sprintf( __( 'Your comment on the post "%s" has been approved.' ), $post->post_title ) . "\r\n\r\n";
+        /* translators: 1: comment permalink */
+        $notify_message .= sprintf( __( 'View comment: %s' ), get_comment_link( $comment ) ) . "\r\n";
+
+        /**
+         * Filter the comment approval notification email text.
+         *
+         * @since 5.7.0
+         *
+         * @param string     $notify_message The comment notification email text.
+         * @param WP_Comment $comment        Comment object.
+         */
+        $notify_message = apply_filters( 'comment_approval_notification_text', $notify_message, $comment );
+
+        /**
+         * Filter the comment approval notification email subject.
+         *
+         * @since 5.7.0
+         *
+         * @param string     $subject The comment notification email subject.
+         * @param WP_Comment $comment Comment object.
+         */
+        $subject = apply_filters( 'comment_approval_notification_subject', $subject, $comment );
+
+        $sent = wp_mail( $comment->comment_author_email, wp_specialchars_decode( $subject ), $notify_message );
+
+        // Delete the opt-in now the notification has been sent.
+        delete_comment_meta( $comment->comment_ID, '_wp_comment_author_notification_optin' );
+
+        return $sent;
+}
+
 /**
  * Sets the status of a comment.
  *

src/wp-includes/default-filters.php

@@ -458 +458 @@
 add_action( 'after_password_reset', 'wp_password_change_notification' );
 add_action( 'register_new_user', 'wp_send_new_user_notifications' );
 add_action( 'edit_user_created_user', 'wp_send_new_user_notifications', 10, 2 );
+add_action( 'comment_unapproved_to_approved', 'wp_new_comment_notify_comment_author' );
 
 // REST API actions.
 add_action( 'init', 'rest_api_init' );

tests/phpunit/tests/comment.php

@@ -554 +554 @@
                 return $notify_message;
         }
 
+        /**
+         * @ticket 33717
+         */
+        public function test_wp_new_comment_notify_comment_author_once_only() {
+                $c = self::factory()->comment->create(
+                        array(
+                                'comment_post_ID'      => self::$post_id,
+                                'comment_approved'     => '0',
+                                'comment_author_email' => 'foo@bar.mail',
+                        )
+                );
+
+                // The user subscribed to receive an email once comment is approved.
+                update_comment_meta( $c, '_wp_comment_author_notification_optin', true );
+
+                // For the purpose of the test we are removing this hook to directly use the function to notify the comment author.
+                remove_action( 'comment_unapproved_to_approved', 'wp_new_comment_notify_comment_author' );
+
+                // Approve the comment.
+                wp_set_comment_status( $c, 'approve' );
+
+                $sent = wp_new_comment_notify_comment_author( $c );
+                $this->assertTrue( $sent );
+
+                $resent = wp_new_comment_notify_comment_author( $c );
+                $this->assertFalse( $resent );
+        }
+
         /**
          * @ticket 12431
          */