Ticket #34012: 34012.diff

src/wp-admin/includes/post.php

@@ -657 +657 @@
 /**
  * Determine if a post exists based on title, content, and date
  *
+ * For best performance use the $date, $type, and $status together
+ * all of which are required to properly use a compound index.
+ * $date is left where it is positionally for legacy reasons
+ *
  * @since 2.0.0
+ * @since 4.4.0 Added the $type, $status parameters
  *
  * @global wpdb $wpdb
  *
@@ -664 +669 @@
  * @param string $title Post title
  * @param string $content Optional post content
  * @param string $date Optional post date
+ * @param string $type Optional post type
+ * @param string $status Optional post status
  * @return int Post ID if post exists, 0 otherwise.
  */
-function post_exists($title, $content = '', $date = '') {
+function post_exists( $title, $content = '', $date = '', $type = '', $status = '' ) {
         global $wpdb;
 
-        $post_title = wp_unslash( sanitize_post_field( 'post_title', $title, 0, 'db' ) );
-        $post_content = wp_unslash( sanitize_post_field( 'post_content', $content, 0, 'db' ) );
-        $post_date = wp_unslash( sanitize_post_field( 'post_date', $date, 0, 'db' ) );
-
-        $query = "SELECT ID FROM $wpdb->posts WHERE 1=1";
-        $args = array();
-
-        if ( !empty ( $date ) ) {
-                $query .= ' AND post_date = %s';
-                $args[] = $post_date;
+        $query = array();
+        foreach( compact( 'title', 'content', 'date', 'type', 'status' ) as $key => $val ) {
+                if ( empty( $val ) ) {
+                        continue;
+                }
+                $key = sprintf( 'post_%s', $key );
+                $query[] = $wpdb->prepare(
+                        $key . ' = %s',
+                        wp_unslash( sanitize_post_field( $key, $val, 0, 'db' ) )
+                );
         }
 
-        if ( !empty ( $title ) ) {
-                $query .= ' AND post_title = %s';
-                $args[] = $post_title;
+        if ( empty( $query ) ) {
+                return 0;
         }
 
-        if ( !empty ( $content ) ) {
-                $query .= 'AND post_content = %s';
-                $args[] = $post_content;
-        }
-
-        if ( !empty ( $args ) )
-                return (int) $wpdb->get_var( $wpdb->prepare($query, $args) );
-
-        return 0;
+        return (int)$wpdb->get_var( "SELECT ID FROM $wpdb->posts WHERE 1=1 AND " . implode( ' AND ', $query ) . ' LIMIT 1' );
 }
 
 /**

tests/phpunit/tests/post/post-exists.php

@@ +1 @@
+<?php
+
+/**
+ * @group post
+ */
+class Tests_Post_Exists extends WP_UnitTestCase {
+        function setUp() {
+                parent::setUp();
+                $this->post1 = $this->factory->post->create( array( 'post_title' => 'Post One Title', 'post_content' => 'Post One Content' ) );
+                $this->post2 = $this->factory->post->create( array( 'post_title' => 'Post Two Title', 'post_content' => 'Post Two Content' ) );
+        }
+
+        function tearDown() {
+                wp_delete_post($this->post1);
+                wp_delete_post($this->post2);
+                parent::tearDown();
+        }
+
+        function test_post_exists_title() {
+                $post = post_exists( 'Post One Title' );
+                $this->assertEquals( $post, $this->post1 );
+        }
+
+        function test_post_exists_bad_title() {
+                $post = post_exists( 'No existing Title' );
+                $this->assertEquals( $post, 0 );
+        }
+
+        function test_post_exists_content() {
+                $post = post_exists( 'Post One Title', 'Post One Content' );
+                $this->assertEquals( $post, $this->post1 );
+        }
+
+}
+ No newline at end of file