Ticket #34195: 34195.deprecate.get_terms_fields.taxonomy-functions.php.patch

wp-includes/taxonomy-functions.php

@@ -1373 +1373 @@
          * parameter alone.
          *
          * Use of this filter can result in unpredictable behavior, and is not recommended.
+         * If using this filter, you should also consider using 'get_terms_fields_terms' to
+         * arrange the output accordingly.
          *
          * @since 2.8.0
          *
@@ -1380 +1382 @@
          * @param array $args       An array of term query arguments.
          * @param array $taxonomies An array of taxonomies.
          */
+        if ( has_filter( 'get_terms_fields' ) ) {
+                _deprecated_function( 'get_terms_fields ' . __( 'hook' ), '4.4.0', 'get_terms ' . __( 'hook' ) )
+        }
         $fields = implode( ', ', apply_filters( 'get_terms_fields', $selects, $args, $taxonomies ) );
 
         $join .= " INNER JOIN $wpdb->term_taxonomy AS tt ON t.term_id = tt.term_id";
@@ -1485 +1490 @@
                 foreach ( $terms as $term ) {
                         $_terms[ $term->term_id ] = $term->slug;
                 }
+        } else {
+
+                /**
+                 * Filter the terms to arrange the return accordingly.
+                 *
+                 * Field lists modified using this filter will only modify the term fields returned
+                 * by the function when the `$fields` parameter set to a custom value different from
+                 * default values.
+                 *
+                 * Use of this filter can result in unpredictable behavior, and is not recommended.
+                 *
+                 * @since 4.4.0
+                 *
+                 * @param array $_terms     An array of terms to return.
+                 * @param string $_fields   Current fields parameter.
+                 * @param array $args       An array of term query arguments.
+                 * @param array $taxonomies An array of taxonomies.
+                 */
+                $_terms = apply_filters( 'get_terms_fields_terms', $_terms, $_fields, $args, $taxonomies );
         }
 
         if ( ! empty( $_terms ) ) {