Ticket #34359: 34359.6.patch

src/wp-includes/functions.php

@@ -1875 +1875 @@
                         $tested_paths = array();
                 }
 
-                if ( array_key_exists( $path, $tested_paths ) ) {
-                        $uploads['error'] = $tested_paths[ $path ];
-                } else {
+                if ( ! in_array( $path, $tested_paths, true ) ) {
                         if ( ! wp_mkdir_p( $path ) ) {
                                 if ( 0 === strpos( $uploads['basedir'], ABSPATH ) ) {
                                         $error_path = str_replace( ABSPATH, '', $uploads['basedir'] ) . $uploads['subdir'];
@@ -1886 +1884 @@
                                 }
 
                                 $uploads['error'] = sprintf( __( 'Unable to create directory %s. Is its parent directory writable by the server?' ), esc_html( $error_path ) );
+                        } else {
+                                $tested_paths[] = $path;
+                                wp_cache_set( 'upload_dir_tested_paths', $tested_paths );
                         }
-
-                        $tested_paths[ $path ] = $uploads['error'];
-                        wp_cache_set( 'upload_dir_tested_paths', $tested_paths );
                 }
         }