Ticket #34560: 34560.3.diff

src/wp-admin/edit-form-advanced.php

@@ -217 +217 @@
 
 $publish_callback_args = null;
 if ( post_type_supports($post_type, 'revisions') && 'auto-draft' != $post->post_status ) {
-        $revisions = wp_get_post_revisions( $post_ID );
-
+        $revision_count = wp_get_post_revision_count( $post_id );
         // We should aim to show the revisions metabox only when there are revisions.
-        if ( count( $revisions ) > 1 ) {
-                reset( $revisions ); // Reset pointer for key()
-                $publish_callback_args = array( 'revisions_count' => count( $revisions ), 'revision_id' => key( $revisions ) );
+        if ( $revision_count > 1 ) {
+                $last_revision = wp_get_last_revision_id( $post_id );
+                $publish_callback_args = array( 'revisions_count' => $revision_count, 'revision_id' => $last_revision ? $last_revision: 0 );
                 add_meta_box('revisionsdiv', __('Revisions'), 'post_revisions_meta_box', null, 'normal', 'core');
         }
 }

src/wp-includes/post-template.php

@@ -1661 +1661 @@
         $autosavef = __( '%1$s [Autosave]' );
         $currentf  = __( '%1$s [Current Revision]' );
 
-        if ( !wp_is_post_revision( $revision ) )
+        if ( !wp_is_post_revision( $revision->ID ) )
                 $revision_date_author = sprintf( $currentf, $revision_date_author );
-        elseif ( wp_is_post_autosave( $revision ) )
+        elseif ( wp_is_post_autosave( $revision->ID ) )
                 $revision_date_author = sprintf( $autosavef, $revision_date_author );
 
         /**
@@ -1700 +1700 @@
                 _deprecated_argument( __FUNCTION__, '3.6' );
         }
 
-        if ( ! $revisions = wp_get_post_revisions( $post->ID ) )
+        if ( ! $revisions = wp_get_post_revisions_details( $post->ID ) )
                 return;
 
         $rows = '';

src/wp-includes/revision.php

@@ -434 +434 @@
 }
 
 /**
+ * Returns the revision details of specified post.
+ *
+ * Data includes details about each revision on a post. Includes ID, post_author,
+ * post_date, post_date_gmt, post_title, post_status, post_parent, and post_modified.
+ *
+ * @since 4.5.0
+ *
+ * @param int|WP_Post $post_id Optional. Post ID or WP_Post object. Default is global $post.
+ * @return array An array of revision details, or an empty array if post invalid.
+ */
+function wp_get_post_revisions_details( $post_id = 0, $args = null ) {
+        global $wpdb;
+
+        $post = get_post( $post_id );
+        if ( ! $post || empty( $post->ID ) ) {
+                return array();
+        }
+
+        $revision_details = $wpdb->get_results(
+                $wpdb->prepare( "
+                        SELECT ID, post_author, post_date, post_date_gmt, post_title, post_status, post_parent, post_modified
+                        FROM $wpdb->posts
+                        WHERE post_parent = %d
+                        AND   post_type   = 'revision'
+                        AND   post_status = 'inherit'
+                        ORDER BY post_date DESC, ID DESC",
+                        $post->ID
+                )
+        );
+
+        return $revision_details;
+}
+
+/**
+ * Return the count of revisions for a given post.
+ *
+ * @since 4.5.0
+ *
+ * @param int|WP_Post $post_id Optional. Post ID or WP_Post object. Default is global $post.
+ * @return int The count of revisions for this post, false if post invalid.
+ */
+function wp_get_post_revision_count( $post_id = 0 ) {
+        global $wpdb;
+
+        $post = get_post( $post_id );
+        if ( ! $post || empty( $post->ID ) ) {
+                return false;
+        }
+
+        $revision_count = intval(
+                $wpdb->get_var(
+                        $wpdb->prepare( "
+                                SELECT COUNT(*)
+                                FROM $wpdb->posts
+                                WHERE post_parent = %d
+                                AND   post_type   = 'revision'
+                                AND   post_status = 'inherit'",
+                        $post->ID
+                        )
+                )
+        );
+        return $revision_count;
+}
+
+/**
+ * Return the id of the last stored revision.
+ *
+ * @since 4.5.0
+ *
+ * @param int|WP_Post $post_id Optional. Post ID or WP_Post object. Default is global $post.
+ * @return int The id of the last stored revision for this post, false if post invalid.
+ */
+function wp_get_last_revision_id( $post_id = 0 ) {
+        global $wpdb;
+
+        $post = get_post( $post_id );
+        if ( ! $post || empty( $post->ID ) ) {
+                return false;
+        }
+
+        $last_revision_id = intval(
+                $wpdb->get_var(
+                        $wpdb->prepare( "
+                                SELECT ID, post_date
+                                FROM $wpdb->posts
+                                WHERE post_parent = %d
+                                AND   post_type   = 'revision'
+                                AND   post_status = 'inherit'
+                                ORDER BY post_date DESC, ID DESC
+                                LIMIT 1",
+                        $post->ID
+                        )
+                )
+        );
+        return $last_revision_id;
+}
+
+/**
  * Determine if revisions are enabled for a given post.
  *
  * @since 3.6.0