Ticket #34945: 34945.4.patch

src/wp-includes/deprecated.php

@@ -3747 +3747 @@
  * @return string The base URL.
  */
 function _wp_upload_dir_baseurl() {
+        _deprecated_function( __FUNCTION__, '4.5' );
         $upload_dir = wp_get_upload_dir();
         return $upload_dir['baseurl'];
 }

src/wp-includes/media.php

@@ -903 +903 @@
 }
 
 /**
+ * Sets the protocol, caches and returns the base URL of the uploads directory.
+ *
+ * @since 4.5.0
+ * @access private
+ *
+ * @param string $baseurl The base URL of the uploads directory.
+ * @return string The base URL, cached.
+ */
+function _ssl_image_baseurl( $baseurl ) {
+        static $tested = array();
+
+        $blog_id = get_current_blog_id();
+
+        if ( empty( $tested[$blog_id] ) ) {
+                /*
+                 * If currently on SSL, prefer HTTPS URLs when we know they're supported by the domain
+                 * (which is to say, when they share the domain name of the current SSL page).
+                 */
+                if ( is_ssl() && 'https' !== substr( $baseurl, 0, 5 ) && parse_url( $baseurl, PHP_URL_HOST ) === $_SERVER['HTTP_HOST'] ) {
+                        $baseurl = set_url_scheme( $baseurl, 'https' );
+                }
+
+                $tested[$blog_id] = $baseurl;
+        }
+
+        return $tested[$blog_id];
+}
+
+/**
  * Get the image size as array from its meta data.
  *
  * Used for responsive images.
@@ -1025 +1054 @@
         }
 
         $upload_dir = wp_get_upload_dir();
-        $image_baseurl = trailingslashit( $upload_dir['baseurl'] ) . $dirname;
 
+        // Set URL schema when front-end is https.
+        $image_baseurl = _ssl_image_baseurl( $upload_dir['baseurl'] );
+        $image_baseurl = trailingslashit( $image_baseurl ) . $dirname;
+
         /*
          * Images that have been edited in WordPress after being uploaded will
          * contain a unique hash. Look for that hash and use it later to filter

tests/phpunit/tests/media.php

@@ -1407 +1407 @@
                 $actual     = wp_make_content_images_responsive( $unfiltered );
 
                 $this->assertSame( $expected, $actual );
+}
+
+        /**
+         * @ticket 34945
+         * @ticket 33641
+         */
+        function test_wp_get_attachment_image_with_https_on() {
+                global $blog_id;
+                
+                // Save server data for cleanup
+                $is_ssl = is_ssl();
+                $current_blog_id = get_current_blog_id();
+
+                // Mock meta for the image.
+                $image_meta = array(
+                        'width' => 1200,
+                        'height' => 600,
+                        'file' => 'test.jpg',
+                        'sizes' => array(
+                                'thumbnail' => array(
+                                        'file' => 'test-150x150.jpg',
+                                        'width' => 150,
+                                        'height' => 150,
+                                ),
+                                'medium' => array(
+                                        'file' => 'test-300x150.jpg',
+                                        'width' => 300,
+                                        'height' => 150,
+                                ),
+                                'large' => array(
+                                        'file' => 'test-1024x512.jpg',
+                                        'width' => 1024,
+                                        'height' => 512,
+                                ),
+                        )
+                );
+
+                // Test using the large file size.
+                $size_array = array(1024, 512);
+                $image_url  = 'http://' . WP_TESTS_DOMAIN . '/wp-content/uploads/' . $image_meta['sizes']['large']['file'];
+
+                $_SERVER['HTTPS'] = 'on';
+                $blog_id = 42; // Used to bust the cache in _ssl_image_baseurl()
+
+                $expected = 'https://example.org/wp-content/uploads/test-300x150.jpg 300w, https://example.org/wp-content/uploads/test-1024x512.jpg 1024w, https://example.org/wp-content/uploads/test.jpg 1200w';
+
+                $this->assertSame( $expected, wp_calculate_image_srcset( $size_array, $image_url, $image_meta ) );
+
+                // Cleanup
+                $_SERVER['HTTPS'] = $is_ssl;
+                $blog_id = $current_blog_id;
         }
 }