Ticket #35075: 35075.2.diff

src/wp-includes/class-wp-comment-query.php

@@ -135 +135 @@
          *
          * Sets up the comment query, based on the query vars passed.
          *
+         * The main comment query is cached, using a key that is generated using the WP_Comment_Query query vars.
+         * In order to minimize cache misses, arguments that are not defined in the `$query_var_defaults` array are
+         * ignored when generating the cache key. If you are passing custom query arguments to WP_Comment_Query, and
+         * you need the query cache to be sensitive to these arguments, add them to the defaults array using the
+         * {@see 'comment_query_defaults'} filter.
+         *
          * @since 4.2.0
          * @since 4.4.0 `$parent__in` and `$parent__not_in` were added.
          * @since 4.4.0 Order by `comment__in` was added. `$update_comment_meta_cache`, `$no_found_rows`,
@@ -245 +251 @@
          * }
          */
         public function __construct( $query = '' ) {
-                $this->query_var_defaults = array(
+                $defaults = array(
                         'author_email' => '',
                         'author_url' => '',
                         'author__in' => '',
@@ -289 +295 @@
                         'update_comment_post_cache' => false,
                 );
 
+                /**
+                 * Filters the default comment query arguments.
+                 *
+                 * @since 4.5.0
+                 *
+                 * @param array $defaults Array of default WP_Comment_Query arguments.
+                 */
+                $this->query_var_defaults = apply_filters( 'comment_query_defaults', $defaults );
+
                 if ( ! empty( $query ) ) {
                         $this->query( $query );
                 }

src/wp-includes/post.php

@@ -4319 +4319 @@
 /**
  * Retrieve a list of pages.
  *
+ * SQL queries in get_pages() are cached, using a key that is generated using the `$args` array. In order to
+ * minimize cache misses, arguments that are not defined in the `$defaults` array are ignored when generating the
+ * cache key. If you are passing custom parameters as part of the `$args` array, and you need the query cache to be
+ * sensitive to these parameters, add them to the `$defaults` array using the {@see 'get_pages_defaults'} filter.
+ *
+ *
  * @global wpdb $wpdb WordPress database abstraction object.
  *
  * @since 1.5.0
@@ -4371 +4377 @@
                 'post_type' => 'page', 'post_status' => 'publish',
         );
 
+        /**
+         * Filters the default page query arguments.
+         *
+         * @since 4.5.0
+         *
+         * @param array $defaults Array of default get_pages() arguments.
+         */
+        $defaults = apply_filters( 'get_pages_defaults', $defaults );
+
         $r = wp_parse_args( $args, $defaults );
 
         $number = (int) $r['number'];

src/wp-includes/taxonomy.php

@@ -1052 +1052 @@
  * The {@see 'list_terms_exclusions'} filter passes the compiled exclusions along with
  * the $args.
  *
+ * SQL queries in get_terms() are cached, using a key that is generated using the `$args` array. In order to
+ * minimize cache misses, arguments that are not defined in the `$defaults` array are ignored when generating the
+ * cache key. If you are passing custom parameters as part of the `$args` array, and you need the query cache to be
+ * sensitive to these parameters, add them to the `$defaults` array using the {@see 'get_terms_defaults'} filter.
+ *
  * The {@see 'get_terms_orderby'} filter passes the `ORDER BY` clause for the query
  * along with the $args array.
  *