Ticket #35112: 35112.2.patch

src/wp-admin/includes/class-wp-screen.php

@@ -998 +998 @@
                  * Filter whether to show the Screen Options submit button.
                  *
                  * @since 4.4.0
-                 * 
+                 *
                  * @param bool      $show_button Whether to show Screen Options submit button.
                  *                               Default false.
                  * @param WP_Screen $this        Current WP_Screen instance.
@@ -1087 +1087 @@
 
                         $id = "$column-hide";
                         echo '<label>';
-                        echo '<input class="hide-column-tog" name="' . $id . '" type="checkbox" value="' . $column . '"' . checked( ! in_array( $column, $hidden ), true, false ) . ' />';
+                        echo '<input class="hide-column-tog" name="' . $id . '" type="checkbox" id="' . $id . '" value="' . $column . '"' . checked( ! in_array( $column, $hidden ), true, false ) . ' />';
                         echo "$title</label>\n";
                 }
                 ?>

src/wp-admin/js/customize-nav-menus.js

@@ -216 +216 @@
                                         .prop( 'tabIndex', -1 )
                                         .removeClass( 'is-visible' );
                         }
-                        
+
                         this.searchTerm = event.target.value;
                         this.pages.search = 1;
                         this.doSearch( 1 );
@@ -631 +631 @@
                 },
 
                 hidden: function() {
-                        this.hidden = function() {
-                                return $( '.hide-column-tog' ).not( ':checked' ).map( function() {
-                                        var id = this.id;
-                                        return id.substring( id, id.length - 5 );
-                                }).get().join( ',' );
-                        };
+                        return $( '.hide-column-tog' ).not( ':checked' ).map( function() {
+                                var id = this.id;
+                                return id.substring( id, id.length - 5 );
+                        }).get().join( ',' );
                 }
         } );
 

src/wp-admin/js/postbox.js

@@ -50 +50 @@
                         this.page = page;
                         this.init( page, args );
 
-                        $handles.on( 'click.postboxes',  this.handle_click );
+                        $handles.on( 'click.postboxes', this.handle_click );
 
                         $('.postbox .hndle a').click( function(e) {
                                 e.stopPropagation();
@@ -157 +157 @@
                 },
 
                 save_state : function(page) {
-                        var closed = $('.postbox').filter('.closed').map(function() { return this.id; }).get().join(','),
-                                hidden = $('.postbox').filter(':hidden').map(function() { return this.id; }).get().join(',');
+                        var closed, hidden;
 
+                        // Return on the nav-menus.php screen, see #35112.
+                        if ( 'nav-menus' === page ) {
+                                return;
+                        }
+
+                        closed = $( '.postbox' ).filter( '.closed' ).map( function() { return this.id; } ).get().join( ',' );
+                        hidden = $( '.postbox' ).filter( ':hidden' ).map( function() { return this.id; } ).get().join( ',' );
+
                         $.post(ajaxurl, {
                                 action: 'closed-postboxes',
                                 closed: closed,