Make WordPress Core

Ticket #35268: 35268-1.diff

File 35268-1.diff, 2.7 KB (added by kingkool68, 10 years ago)
  • src/wp-includes/general-template.php

     
    34483448 * @return string html attribute or empty string
    34493449 */
    34503450function __checked_selected_helper( $helper, $current, $echo, $type ) {
    3451         if ( (string) $helper === (string) $current )
     3451        $result = '';
     3452        if ( is_array( $helper ) ) {
     3453                if ( in_array( (string) $current, $helper, true )  ) {
     3454                        $result = " $type='$type'";
     3455                }
     3456        } else if ( (string) $helper === (string) $current ) {
    34523457                $result = " $type='$type'";
    3453         else
    3454                 $result = '';
     3458        }
    34553459
    34563460        if ( $echo )
    34573461                echo $result;
  • tests/phpunit/tests/admin/includesTemplate.php

     
    77                $this->assertEquals(' selected=\'selected\'', selected('foo','foo',false));
    88                $this->assertEquals(' checked=\'checked\'', checked('foo','foo',false));
    99
     10                $this->assertEquals(' selected=\'selected\'', selected(array('bar', 'foo'),'foo',false));
     11                $this->assertEquals(' checked=\'checked\'', checked(array('bar', 'foo'), 'foo',false));
     12
    1013                $this->assertEquals(' selected=\'selected\'', selected('1',1,false));
    1114                $this->assertEquals(' checked=\'checked\'', checked('1',1,false));
    1215
     
    3942                $this->assertEquals('', selected('0','',false));
    4043                $this->assertEquals('', checked('0','',false));
    4144
     45                $this->assertEquals('', selected(array('bar', 'baz'),'foo',false));
     46                $this->assertEquals('', checked(array('bar', 'baz'),'foo',false));
     47
    4248                $this->assertEquals('', selected(0,'',false));
    4349                $this->assertEquals('', checked(0,'',false));
    4450
     
    5056                global $wp_meta_boxes;
    5157
    5258                add_meta_box( 'testbox1', 'Test Metabox', '__return_false', 'post' );
    53                
     59
    5460                $this->assertArrayHasKey( 'testbox1', $wp_meta_boxes['post']['advanced']['default'] );
    5561        }
    5662
     
    7985                // Add a meta box to three different post types
    8086                add_meta_box( 'testbox1', 'Test Metabox', '__return_false', array( 'post', 'comment', 'attachment' ) );
    8187
    82                 $this->assertArrayHasKey( 'testbox1', $wp_meta_boxes['post']['advanced']['default'] ); 
     88                $this->assertArrayHasKey( 'testbox1', $wp_meta_boxes['post']['advanced']['default'] );
    8389                $this->assertArrayHasKey( 'testbox1', $wp_meta_boxes['comment']['advanced']['default'] );
    8490                $this->assertArrayHasKey( 'testbox1', $wp_meta_boxes['attachment']['advanced']['default'] );
    8591        }
     
    108114                $this->assertFalse( $wp_meta_boxes['attachment']['advanced']['default']['testbox1'] );
    109115        }
    110116
    111 }
    112  No newline at end of file
     117}